Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 526193002: use c++03 style enum scope (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
Reviewers:
michaeln, sof, jkarlin, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

use c++03 style enum scope Followup to https://codereview.chromium.org/411973004 We haven't officially switched over to using c++11 everywhere yet, so this patch replaces c++11 style enum scope with c++03 style scope. BUG=392621 Committed: https://crrev.com/23a9a22b232c86d47edc1b6c7f7e9e677931252e Cr-Commit-Position: refs/heads/master@{#292902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M content/browser/service_worker/service_worker_cache_listener.cc View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mostyn Bramley-Moore
@michaeln, jkarlin: please take a look at this tiny patch.
6 years, 3 months ago (2014-09-01 19:34:21 UTC) #2
nhiroki
LGTM (other reviewers seems to be on the national holiday)
6 years, 3 months ago (2014-09-02 01:59:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/526193002/1
6 years, 3 months ago (2014-09-02 06:26:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as e728f7b0e2d56628891c1b55bb30016b6019133a
6 years, 3 months ago (2014-09-02 07:22:35 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23a9a22b232c86d47edc1b6c7f7e9e677931252e
Cr-Commit-Position: refs/heads/master@{#292902}

Powered by Google App Engine
This is Rietveld 408576698