Stitch CacheStorage messages to implementation.

Stitch CacheStorage messages to the implementation

Also do a bit of renaming from Stores -> Cache while we're at it.

BUG=392621
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289036

[jkarlin, 2014-08-11 12:14:22]

michaeln@chromium.org: Please review changes in everything

falken@chromium.org: Please review changes in everything

gavinp@chromium.org: FYI

[falken, 2014-08-12 01:37:33]

lgtm if comment is addressed

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
File content/browser/service_worker/service_worker_cache_listener.cc (right):

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.cc:155: request_id,
ToWebServiceWorkerCacheError(error)));
Looks like HasCache returns false with NO_ERROR when not found. So
ToWebServiceWorkerCacheError will DCHECK.

[michaeln, 2014-08-12 03:59:23]

lgtm

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
File content/browser/service_worker/service_worker_cache_listener.cc (right):

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.cc:22:
content::ServiceWorkerCacheStorage::CacheStorageError err) {
nit: i think content:: not needed here and below

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.cc:198:
string16s.push_back(base::UTF8ToUTF16(strings[i]));
nit: the type translation to blink'ish speak (WebServiceWorkerCacheError and
widestrings) is something that seems like a function of the renderer process. i
probably should have mentioned that in an earlier review.

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
File content/browser/service_worker/service_worker_cache_listener.h (right):

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.h:41: void
OnCacheStorageGetCallback(
i like the method naming!

[jkarlin, 2014-08-12 15:17:48]

Thanks!

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
File content/browser/service_worker/service_worker_cache_listener.cc (right):

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.cc:22:
content::ServiceWorkerCacheStorage::CacheStorageError err) {
On 2014/08/12 03:59:23, michaeln wrote:
> nit: i think content:: not needed here and below

Done.

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.cc:155: request_id,
ToWebServiceWorkerCacheError(error)));
On 2014/08/12 01:37:33, falken wrote:
> Looks like HasCache returns false with NO_ERROR when not found. So
> ToWebServiceWorkerCacheError will DCHECK.

Great catch! Thanks. Done.

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.cc:198:
string16s.push_back(base::UTF8ToUTF16(strings[i]));
On 2014/08/12 03:59:23, michaeln wrote:
> nit: the type translation to blink'ish speak (WebServiceWorkerCacheError and
> widestrings) is something that seems like a function of the renderer process.
i
> probably should have mentioned that in an earlier review.

Looking at service_worker_messages.h it looks like we always send string16 over
IPC. Shouldn't this be too?

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
File content/browser/service_worker/service_worker_cache_listener.h (right):

https://codereview.chromium.org/411973004/diff/100001/content/browser/service...
content/browser/service_worker/service_worker_cache_listener.h:41: void
OnCacheStorageGetCallback(
On 2014/08/12 03:59:23, michaeln wrote:
> i like the method naming!

Thanks :)

[jkarlin, 2014-08-12 17:47:46]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-08-12 17:48:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/411973004/120001

[commit-bot: I haz the power, 2014-08-12 18:41:05]

Change committed as 289036