Issue 526173003: Change VideoTrackAdapter to not drop frames if the source frame rate is known. Also change remote v…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 526173003: Change VideoTrackAdapter to not drop frames if the source frame rate is known. Also change remote v… (Closed)

Created:
6 years, 3 months ago by perkj_chrome

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change VideoTrackAdapter to not drop frames if the source frame rate is known. Also change remote video and pepper plugin MediaStreamVideoSource implementations to not set a guessed frame rate. BUG=394315 Review URL: https://codereview.chromium.org/517973002 Cr-Commit-Position: refs/heads/master@{#292800} (cherry picked from commit b18d81f67b126ff6513b6b442d93138958fa156e) Committed: https://chromium.googlesource.com/chromium/src/+/9ec39908c2294c68328a8332fbe179b371a4a902

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -7 lines)			Patch
M	content/renderer/media/media_stream_video_source.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/media_stream_video_source.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/video_track_adapter.cc	View	4 chunks	+13 lines, -5 lines	0 comments	Download
M	content/renderer/media/webrtc/media_stream_remote_video_source.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/webrtc/video_destination_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 9ec3990.

Expand Messages | Collapse Messages