Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 517973002: Change VideoTrackAdapter to not drop frames if the source frame rate is known. (Closed)

Created:
6 years, 3 months ago by perkj_chrome
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change VideoTrackAdapter to not drop frames if the source frame rate is known. Also change remote video and pepper plugin MediaStreamVideoSource implementations to not set a guessed frame rate. BUG=394315 Committed: https://crrev.com/b18d81f67b126ff6513b6b442d93138958fa156e Cr-Commit-Position: refs/heads/master@{#292800}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M content/renderer/media/media_stream_video_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 4 chunks +13 lines, -5 lines 1 comment Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
perkj_chrome
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-29 08:36:53 UTC) #1
perkj_chrome
perkj@chromium.org changed reviewers: + mcasas@chromium.org, tommi@chromium.org
6 years, 3 months ago (2014-08-29 08:37:48 UTC) #2
perkj_chrome
Can you please review?
6 years, 3 months ago (2014-08-29 08:37:48 UTC) #3
mcasas
lgtm
6 years, 3 months ago (2014-08-29 14:11:29 UTC) #4
perkj_chrome
Tommi - please click the CQ if you approve....
6 years, 3 months ago (2014-08-29 14:13:04 UTC) #5
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/517973002/diff/20001/content/renderer/media/video_track_adapter.cc File content/renderer/media/video_track_adapter.cc (right): https://codereview.chromium.org/517973002/diff/20001/content/renderer/media/video_track_adapter.cc#newcode236 content/renderer/media/video_track_adapter.cc:236: source_frame_rate <= max_frame_rate_)) nit: there should have been ...
6 years, 3 months ago (2014-08-30 17:40:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/517973002/20001
6 years, 3 months ago (2014-08-30 17:41:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001) as bec968853081ac55be96273d9b22794a02b6a76f
6 years, 3 months ago (2014-08-30 18:30:47 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b18d81f67b126ff6513b6b442d93138958fa156e
Cr-Commit-Position: refs/heads/master@{#292800}

Powered by Google App Engine
This is Rietveld 408576698