Issue 526043002: Refactor libplatform unit tests to use GTest/GMock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 526043002: Refactor libplatform unit tests to use GTest/GMock. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Refactor libplatform unit tests to use GTest/GMock. Also migrate them to src. BUG=v8:3489 LOG=n R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23541

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -335 lines)			Patch
M	build/all.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/libplatform/default-platform-unittest.cc	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A +	src/libplatform/libplatform.gyp	View		1 chunk	+7 lines, -13 lines	0 comments	Download
A	src/libplatform/task-queue-unittest.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download
A	src/libplatform/worker-thread-unittest.cc	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.gyp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	test/cctest/test-libplatform.h	View		1 chunk	+0 lines, -123 lines	0 comments	Download
D	test/cctest/test-libplatform-default-platform.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download
D	test/cctest/test-libplatform-task-queue.cc	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	test/cctest/test-libplatform-worker-thread.cc	View		1 chunk	+0 lines, -65 lines	0 comments	Download
A +	test/libplatform-unittests/libplatform-unittests.status	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/libplatform-unittests/testcfg.py	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/presubmit.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/run-tests.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

6 years, 3 months ago (2014-09-01 07:14:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 23541 (presubmit successful).