Issue 526012: Merge 32345 - Parse messages.json in ExtensionUnpacker (like we do for manife...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 526012: Merge 32345 - Parse messages.json in ExtensionUnpacker (like we do for manife... (Closed)

Created:
10 years, 11 months ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
Nebojša Ćirić

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 32345 - Parse messages.json in ExtensionUnpacker (like we do for manifest) and pass them to sandboxed_extension_unpacker. Added unittest files for unpacker and sandboxed unpacker. TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail. BUG=27362 Review URL: http://codereview.chromium.org/390019 TBR=cira@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35547

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+441 lines, -104 lines)			Patch
M	chrome/browser/extensions/extension_file_util.cc	View	3 chunks	+72 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.h	View	4 chunks	+16 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.cc	View	5 chunks	+140 lines, -78 lines	0 comments	Download
A +	chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/utility_process_host.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.cc	View	5 chunks	+72 lines, -2 lines	0 comments	Download
A +	chrome/common/extensions/extension_unpacker_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 chunk	+7 lines, -5 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/empty_default_locale.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/empty_default_locale/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/good_l10n.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US/messages.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/good_l10n/_locales/sr/messages.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/good_l10n/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/has_default_missing_locales.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/has_default_missing_locales/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/invalid_default_locale.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/invalid_default_locale/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/invalid_messages_file.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US/messages.json	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/invalid_messages_file/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/missing_default_data.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US/messages.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/missing_default_data/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/missing_default_has_locales.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/missing_default_has_locales/manifest.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/missing_messages_file.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/missing_messages_file/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/no_l10n.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/no_l10n/manifest.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/unpacker/no_locale_data.crx	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/unpacker/no_locale_data/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/utility/utility_thread.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages