chrome/common/render_messages_internal.h - Issue 526012: Merge 32345 - Parse messages.json in ExtensionUnpacker (like we do for manife...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/render_messages_internal.h

Issue 526012: Merge 32345 - Parse messages.json in ExtensionUnpacker (like we do for manife... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/249/src/

Patch Set: Created 10 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_unpacker_unittest.cc ('k') | chrome/test/data/extensions/unpacker/empty_default_locale.crx » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/render_messages_internal.h

===================================================================

--- chrome/common/render_messages_internal.h (revision 35541)

+++ chrome/common/render_messages_internal.h (working copy)

@@ -1886,11 +1886,13 @@

// because we ran out of spare message types.

// Reply when the utility process is done unpacking an extension. |manifest|

- // is the parsed manifest.json file. The unpacker should also have written

- // out a file containing decoded images from the extension. See

- // ExtensionUnpacker for details.

- IPC_MESSAGE_CONTROL1(UtilityHostMsg_UnpackExtension_Succeeded,

- DictionaryValue /* manifest */)

+ // is the parsed manifest.json file. |catalogs| is the list of all parsed

+ // message catalogs and relative paths to them.

+ // The unpacker should also have written out a file containing decoded images

+ // from the extension. See ExtensionUnpacker for details.

+ IPC_MESSAGE_CONTROL2(UtilityHostMsg_UnpackExtension_Succeeded,

+ DictionaryValue /* manifest */,

+ DictionaryValue /* catalogs */)

// Reply when the utility process has failed while unpacking an extension.

// |error_message| is a user-displayable explanation of what went wrong.