Issue 52563002: Remove TextTrackResource

Issue 52563002: Remove TextTrackResource (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin

CC:
blink-reviews, Nate Chapin, nessy, vcarbune.chromium, philipj_slow, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@dataReceived

Visibility:
Public.

More Reviews

Description

Remove TextTrackResource It's now just a RawResource, so use that instead. BUG=312756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160974

Patch Set 2 : simplify #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -102 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/fetch/ResourceFetcher.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/fetch/ResourceFetcher.cpp	View	1	4 chunks	+2 lines, -9 lines	0 comments	Download
D	Source/core/fetch/TextTrackResource.h	View		1 chunk	+0 lines, -41 lines	0 comments	Download
D	Source/core/fetch/TextTrackResource.cpp	View		1 chunk	+0 lines, -44 lines	0 comments	Download
M	Source/core/loader/TextTrackLoader.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/loader/TextTrackLoader.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

lgtm with a nit https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp#newcode97 Source/core/fetch/ResourceFetcher.cpp:97: case Resource::TextTrack: Nit: move this ...

7 years, 1 month ago (2013-10-30 16:30:53 UTC) #2

philipj_slow

https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp#newcode97 Source/core/fetch/ResourceFetcher.cpp:97: case Resource::TextTrack: On 2013/10/30 16:30:53, Nate Chapin wrote: > ...

7 years, 1 month ago (2013-10-30 19:51:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52563002/60001

7 years, 1 month ago (2013-10-30 20:15:31 UTC) #4

Message was sent while issue was closed.

Change committed as 160974

Expand Messages | Collapse Messages