Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 52563002: Remove TextTrackResource (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Nate Chapin, nessy, vcarbune.chromium, philipj_slow, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@dataReceived
Visibility:
Public.

Description

Remove TextTrackResource It's now just a RawResource, so use that instead. BUG=312756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160974

Patch Set 1 #

Total comments: 2

Patch Set 2 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -102 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 4 chunks +2 lines, -9 lines 0 comments Download
D Source/core/fetch/TextTrackResource.h View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/core/fetch/TextTrackResource.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/core/loader/TextTrackLoader.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
Part 4/4.
5 years ago (2013-10-30 13:26:11 UTC) #1
Nate Chapin
lgtm with a nit https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp#newcode97 Source/core/fetch/ResourceFetcher.cpp:97: case Resource::TextTrack: Nit: move this ...
5 years ago (2013-10-30 16:30:53 UTC) #2
philipj_slow
https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/52563002/diff/1/Source/core/fetch/ResourceFetcher.cpp#newcode97 Source/core/fetch/ResourceFetcher.cpp:97: case Resource::TextTrack: On 2013/10/30 16:30:53, Nate Chapin wrote: > ...
5 years ago (2013-10-30 19:51:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52563002/60001
5 years ago (2013-10-30 20:15:31 UTC) #4
commit-bot: I haz the power
5 years ago (2013-10-30 21:48:49 UTC) #5
Message was sent while issue was closed.
Change committed as 160974

Powered by Google App Engine
This is Rietveld 408576698