Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 525433003: [Findit] Use a thread pool. (Closed)

Created:
6 years, 3 months ago by stgao
Modified:
4 years, 7 months ago
Reviewers:
Martin Barbella, aarya
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Findit] Use a thread pool. Currently, Findit starts and joins threads in a few places. This is not elegant from the perspective of design and not good for performance due to the overhead of starting/joining of threads. This CL is to create a shared thread pool to execute tasks just like a task queue. NOTRY=true Committed: https://crrev.com/41ddc64aba525d5ba456d7a45b2842bad8515c7f Cr-Commit-Position: refs/heads/master@{#292985}

Patch Set 1 #

Patch Set 2 : Fix blame.py #

Total comments: 2

Patch Set 3 : Revert print. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -47 lines) Patch
M tools/findit/blame.py View 1 3 chunks +10 lines, -13 lines 0 comments Download
M tools/findit/crash_utils.py View 2 chunks +52 lines, -0 lines 0 comments Download
M tools/findit/findit_for_crash.py View 6 chunks +16 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
stgao
https://codereview.chromium.org/525433003/diff/20001/tools/findit/common/http_client_local.py File tools/findit/common/http_client_local.py (right): https://codereview.chromium.org/525433003/diff/20001/tools/findit/common/http_client_local.py#newcode231 tools/findit/common/http_client_local.py:231: print 'requesting url: %s' % url I will revert ...
6 years, 3 months ago (2014-08-29 22:47:36 UTC) #2
stgao
https://codereview.chromium.org/525433003/diff/20001/tools/findit/crash_utils.py File tools/findit/crash_utils.py (right): https://codereview.chromium.org/525433003/diff/20001/tools/findit/crash_utils.py#newcode19 tools/findit/crash_utils.py:19: MAX_THREAD_NUMBER = 10 How many threads do you guys ...
6 years, 3 months ago (2014-08-29 22:48:49 UTC) #3
aarya
lgtm. 10 is fine. please update cf code as well.
6 years, 3 months ago (2014-08-31 01:02:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stgao@chromium.org/525433003/40001
6 years, 3 months ago (2014-09-02 18:33:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stgao@chromium.org/525433003/40001
6 years, 3 months ago (2014-09-02 19:46:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e626b6cdd5117976c58cb4c4c9e12bad7c977658
6 years, 3 months ago (2014-09-02 20:14:24 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:22 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/41ddc64aba525d5ba456d7a45b2842bad8515c7f
Cr-Commit-Position: refs/heads/master@{#292985}

Powered by Google App Engine
This is Rietveld 408576698