tools/findit/common/http_client_local.py - Issue 525433003: [Findit] Use a thread pool.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/findit/common/http_client_local.py

Issue 525433003: [Findit] Use a thread pool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix blame.py Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """	5 """

6 A http client with support for https connections with certificate verification.	6 A http client with support for https connections with certificate verification.

7	7

8 The verification is based on http://tools.ietf.org/html/rfc6125#section-6.4.3	8 The verification is based on http://tools.ietf.org/html/rfc6125#section-6.4.3

9 and the code is from Lib/ssl.py in python3:	9 and the code is from Lib/ssl.py in python3:

10 http://hg.python.org/cpython/file/4dac45f88d45/Lib/ssl.py	10 http://hg.python.org/cpython/file/4dac45f88d45/Lib/ssl.py

(...skipping 210 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
221 return status_code, content	221 return status_code, content

222	222

223	223

224 class HttpClientLocal(http_client.HttpClient):	224 class HttpClientLocal(http_client.HttpClient):

225 """This http client is used locally in a workstation, GCE VMs, etc."""	225 """This http client is used locally in a workstation, GCE VMs, etc."""

226	226

227 @staticmethod	227 @staticmethod

228 def Get(url, params={}, timeout=None):	228 def Get(url, params={}, timeout=None):

229 if params:	229 if params:

230 url = '%s?%s' % (url, urllib.urlencode(params))	230 url = '%s?%s' % (url, urllib.urlencode(params))

231 return _SendRequest(url, timeout=timeout)	231 print 'requesting url: %s' % url
	stgao 2014/08/29 22:47:36 I will revert this before committing. I'm running I will revert this before committing. I'm running the benchmark to check how many duplicate url request are there.
	232 status_code, content = _SendRequest(url, timeout=timeout)

	233 return status_code, content

OLD	NEW

« no previous file with comments | « tools/findit/blame.py ('k') | tools/findit/crash_utils.py » ('j') | tools/findit/crash_utils.py » ('J')