Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: base/sync_socket_nacl.cc

Issue 525313002: SyncSocket Transit Descriptor - refactoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased on master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/sync_socket_nacl.cc
diff --git a/base/sync_socket_nacl.cc b/base/sync_socket_nacl.cc
index f6d17e7ffb61dc20468bbd4e987c927171273f11..0df6ed685ad9b6de89adc6b8f31c6ee3e33247f7 100644
--- a/base/sync_socket_nacl.cc
+++ b/base/sync_socket_nacl.cc
@@ -27,6 +27,19 @@ bool SyncSocket::CreatePair(SyncSocket* socket_a, SyncSocket* socket_b) {
return false;
}
+// static
+SyncSocket::Handle SyncSocket::UnwrapHandle(
+ const SyncSocket::TransitDescriptor& descriptor) {
+ NOTIMPLEMENTED();
henrika (OOO until Aug 14) 2014/09/01 14:30:43 Add TODO and link to issue in crbug.
burnik 2014/09/01 14:59:33 Done.
+ return SyncSocket::kInvalidHandle;
+}
+
+bool SyncSocket::PrepareTransitDescriptor(ProcessHandle peer_process_handle,
+ SyncSocket::TransitDescriptor * descriptor) {
no longer working on chromium 2014/09/01 14:56:18 indentation. run git-clang-format
burnik 2014/09/01 15:08:02 Done.
+ NOTIMPLEMENTED();
henrika (OOO until Aug 14) 2014/09/01 14:30:43 Same here.
burnik 2014/09/01 14:59:33 Done.
+ return false;
+}
+
bool SyncSocket::Close() {
if (handle_ != kInvalidHandle) {
if (close(handle_) < 0)

Powered by Google App Engine
This is Rietveld 408576698