SyncSocket Transit Descriptor - refactoring

base/sync_socket_nacl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sync_socket.h"
 
 #include <errno.h>
 #include <limits.h>
 #include <stdio.h>
 #include <sys/types.h>
 
 #include "base/logging.h"
 
 namespace base {
 
 const SyncSocket::Handle SyncSocket::kInvalidHandle = -1;
 
 SyncSocket::SyncSocket() : handle_(kInvalidHandle) {
 }
 
 SyncSocket::~SyncSocket() {
   Close();
 }
 
 // static
 bool SyncSocket::CreatePair(SyncSocket* socket_a, SyncSocket* socket_b) {
   return false;
 }
 
+// static
+SyncSocket::Handle SyncSocket::UnwrapHandle(
+    const SyncSocket::TransitDescriptor& descriptor) {
+  NOTIMPLEMENTED();

[henrika (OOO until Aug 14), 2014/09/01 14:30:43]

Add TODO and link to issue in crbug.

[burnik, 2014/09/01 14:59:33]

Done.

+  return SyncSocket::kInvalidHandle;
+}
+
+bool SyncSocket::PrepareTransitDescriptor(ProcessHandle peer_process_handle,
+    SyncSocket::TransitDescriptor * descriptor) {

[no longer working on chromium, 2014/09/01 14:56:18]

indentation. run git-clang-format

[burnik, 2014/09/01 15:08:02]

Done.

+  NOTIMPLEMENTED();

[henrika (OOO until Aug 14), 2014/09/01 14:30:43]

Same here.

[burnik, 2014/09/01 14:59:33]

Done.

+  return false;
+}
+
 bool SyncSocket::Close() {
   if (handle_ != kInvalidHandle) {
     if (close(handle_) < 0)
       DPLOG(ERROR) << "close";
     handle_ = kInvalidHandle;
   }
   return true;
 }
 
 size_t SyncSocket::Send(const void* buffer, size_t length) {
@@ skipping 31 matching lines @@
   return SyncSocket::Close();
 }
 
 // static
 bool CancelableSyncSocket::CreatePair(CancelableSyncSocket* socket_a,
                                       CancelableSyncSocket* socket_b) {
   return SyncSocket::CreatePair(socket_a, socket_b);
 }
 
 }  // namespace base