Domain Reliability: Don't create Service if metrics reporting disabled

Domain Reliability: Don't create Service if metrics reporting disabled

Given that the metrics reporting pref is labelled in the UI as requiring
a restart to apply, this is a much simpler way of gating Domain
Reliability uploads on it.

We simply don't create the Service (so we don't collect data and upload
it) if the pref is false.

This will need to be revisited when we also start using the Monitor for
JavaScript hooks (e.g. the Navigation Error Logging API).

BUG=407170
Committed: https://crrev.com/8d0540250a09769fa5f3a323302ceb4a0d498a51
Cr-Commit-Position: refs/heads/master@{#293226}

[Deprecated (see juliatuttle), 2014-09-02 15:53:36]

ttuttle@chromium.org changed reviewers:
+ mmenke@chromium.org

[Deprecated (see juliatuttle), 2014-09-02 15:53:38]

PTAL, mmenke. (This is a very tiny version of the earlier UMA change.)

[mmenke, 2014-09-02 18:45:40]

https://codereview.chromium.org/525303004/diff/1/chrome/browser/domain_reliab...
File chrome/browser/domain_reliability/service_factory.cc (right):

https://codereview.chromium.org/525303004/diff/1/chrome/browser/domain_reliab...
chrome/browser/domain_reliability/service_factory.cc:55:
g_browser_process->local_state());
Do we even need this member variable?  Seems like we can just grab it in
BuildServiceInstanceFor.

[Deprecated (see juliatuttle), 2014-09-02 20:41:27]

PTAL, mmenke.

https://codereview.chromium.org/525303004/diff/1/chrome/browser/domain_reliab...
File chrome/browser/domain_reliability/service_factory.cc (right):

https://codereview.chromium.org/525303004/diff/1/chrome/browser/domain_reliab...
chrome/browser/domain_reliability/service_factory.cc:55:
g_browser_process->local_state());
On 2014/09/02 18:45:40, mmenke wrote:
> Do we even need this member variable?  Seems like we can just grab it in
> BuildServiceInstanceFor.

Yeah, maybe you're right.

[Deprecated (see juliatuttle), 2014-09-03 14:55:31]

PTAL, mmenke.

[mmenke, 2014-09-03 14:59:47]

https://codereview.chromium.org/525303004/diff/20001/chrome/browser/domain_re...
File chrome/browser/domain_reliability/service_factory.h (right):

https://codereview.chromium.org/525303004/diff/20001/chrome/browser/domain_re...
chrome/browser/domain_reliability/service_factory.h:39: bool reporting_enabled_;
I don't think this is needed, either, is it?  We can just grab it in
DomainReliabilityServiceFactory::BuildServiceInstanceFor.

[Deprecated (see juliatuttle), 2014-09-03 17:05:59]

PTAL, mmenke.

[mmenke, 2014-09-03 17:12:40]

LGTM

https://codereview.chromium.org/525303004/diff/40001/chrome/browser/domain_re...
File chrome/browser/domain_reliability/service_factory.cc (right):

https://codereview.chromium.org/525303004/diff/40001/chrome/browser/domain_re...
chrome/browser/domain_reliability/service_factory.cc:64: return NULL;
nit:  Use braces when the conditional takes up multiple lines.

[Deprecated (see juliatuttle), 2014-09-03 19:26:42]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2014-09-03 19:28:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ttuttle@chromium.org/525303004/60001

[commit-bot: I haz the power, 2014-09-03 20:31:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-09-03 23:57:54]

Committed patchset #4 (id:60001) as cc49de567a96b0436dae30c979b85fae2aeea47b

[commit-bot: I haz the power, 2014-09-10 03:28:43]

Patchset 4 (id:??) landed as
https://crrev.com/8d0540250a09769fa5f3a323302ceb4a0d498a51
Cr-Commit-Position: refs/heads/master@{#293226}