Domain Reliability: Don't create Service if metrics reporting disabled

chrome/browser/domain_reliability/service_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/domain_reliability/service_factory.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
 #include "components/domain_reliability/service.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "content/public/browser/browser_context.h"
 
 namespace domain_reliability {
 
 namespace {
 
 // Identifies Chrome as the source of Domain Reliability uploads it sends.
 const char* kDomainReliabilityUploadReporterString = "chrome";
@@ skipping 20 matching lines @@
 
 // static
 DomainReliabilityServiceFactory*
 DomainReliabilityServiceFactory::GetInstance() {
   return Singleton<DomainReliabilityServiceFactory>::get();
 }
 
 DomainReliabilityServiceFactory::DomainReliabilityServiceFactory()
     : BrowserContextKeyedServiceFactory(
           "DomainReliabilityService",
-          BrowserContextDependencyManager::GetInstance()) {}
+          BrowserContextDependencyManager::GetInstance()) {
+  reporting_pref_.Init(prefs::kMetricsReportingEnabled,
+                       g_browser_process->local_state());

[mmenke, 2014/09/02 18:45:40]

Do we even need this member variable?  Seems like we can just grab it in
BuildServiceInstanceFor.

[Deprecated (see juliatuttle), 2014/09/02 20:41:27]

Yeah, maybe you're right.

+}
 
 DomainReliabilityServiceFactory::~DomainReliabilityServiceFactory() {}
 
 KeyedService* DomainReliabilityServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   if (!IsDomainReliabilityMonitoringEnabled())
     return NULL;
 
+  if (!*reporting_pref_)
+    return NULL;
+
   return DomainReliabilityService::Create(
       kDomainReliabilityUploadReporterString);
 }
 
 }  // namespace domain_reliability