Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: cloud_print/service/win/cloud_print_service.cc

Issue 525013003: Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cloud_print/gcp20/prototype/x_privet_token.cc ('k') | rlz/win/lib/machine_deal_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/service/win/cloud_print_service.cc
diff --git a/cloud_print/service/win/cloud_print_service.cc b/cloud_print/service/win/cloud_print_service.cc
index 6f580951584057c1a475264446ca7ac0bd05d808..2e153988fcaca359c60f340f01a3a3148fd10a4f 100644
--- a/cloud_print/service/win/cloud_print_service.cc
+++ b/cloud_print/service/win/cloud_print_service.cc
@@ -80,10 +80,11 @@
std::cout << "\n";
}
-base::string16 GetOption(int string_id, const base::string16& default,
- bool secure) {
+base::string16 GetOption(int string_id,
+ const base::string16& default_option,
+ bool secure) {
base::string16 prompt_format = cloud_print::LoadLocalString(string_id);
- std::vector<base::string16> substitutions(1, default);
+ std::vector<base::string16> substitutions(1, default_option);
std::cout << ReplaceStringPlaceholders(prompt_format, substitutions, NULL);
base::string16 tmp;
if (secure) {
@@ -99,7 +100,7 @@
std::getline(std::wcin, tmp);
}
if (tmp.empty())
- return default;
+ return default_option;
return tmp;
}
« no previous file with comments | « cloud_print/gcp20/prototype/x_privet_token.cc ('k') | rlz/win/lib/machine_deal_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698