Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests.

rlz/win/lib/machine_deal_test.cc

Index: rlz/win/lib/machine_deal_test.cc
diff --git a/rlz/win/lib/machine_deal_test.cc b/rlz/win/lib/machine_deal_test.cc
index 47b72656c79680d22017e3761e878091a6d0aba2..ec0526fde9c78ea6fb618b63bb433bb18b50213c 100644
--- a/rlz/win/lib/machine_deal_test.cc
+++ b/rlz/win/lib/machine_deal_test.cc
@@ -72,7 +72,7 @@
 
   // Bad responses
 
-  char* kBadDccResponse =
+  const char kBadDccResponse[] =
     "dcc: NotMyDCCode \r\n"
     "set_dcc: NewDCCode\r\n"
     "crc32: 1B4D6BB3";
@@ -81,7 +81,7 @@
   EXPECT_TRUE(rlz_lib::MachineDealCode::Get(dcc_50, 50));
   EXPECT_STREQ("MyDCCode", dcc_50);
 
-  char* kBadCrcResponse =
+  const char kBadCrcResponse[] =
     "dcc: MyDCCode \r\n"
     "set_dcc: NewDCCode\r\n"
     "crc32: 90707106";
@@ -92,7 +92,7 @@
 
   // Good responses
 
-  char* kMissingSetResponse =
+  const char kMissingSetResponse[] =
     "dcc: MyDCCode \r\n"
     "crc32: 35F2E717";
   EXPECT_TRUE(rlz_lib::MachineDealCode::SetFromPingResponse(
@@ -100,7 +100,7 @@
   EXPECT_TRUE(rlz_lib::MachineDealCode::Get(dcc_50, 50));
   EXPECT_STREQ("MyDCCode", dcc_50);
 
-  char* kGoodResponse =
+  const char kGoodResponse[] =
     "dcc: MyDCCode \r\n"
     "set_dcc: NewDCCode\r\n"
     "crc32: C8540E02";
@@ -109,7 +109,7 @@
   EXPECT_TRUE(rlz_lib::MachineDealCode::Get(dcc_50, 50));
   EXPECT_STREQ("NewDCCode", dcc_50);
 
-  char* kGoodResponse2 =
+  const char kGoodResponse2[] =
     "set_dcc: NewDCCode2  \r\n"
     "dcc:   NewDCCode \r\n"
     "crc32: 60B6409A";
@@ -119,7 +119,7 @@
   EXPECT_STREQ("NewDCCode2", dcc_50);
 
   MachineDealCodeHelper::Clear();
-  char* kGoodResponse3 =
+  const char kGoodResponse3[] =
     "set_dcc: NewDCCode  \r\n"
     "crc32: 374C1C47";
   EXPECT_TRUE(rlz_lib::MachineDealCode::SetFromPingResponse(
@@ -128,7 +128,7 @@
   EXPECT_STREQ("NewDCCode", dcc_50);
 
   MachineDealCodeHelper::Clear();
-  char* kGoodResponse4 =
+  const char kGoodResponse4[] =
     "dcc:   \r\n"
     "set_dcc: NewDCCode  \r\n"
     "crc32: 0AB1FB39";