Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 525013003: Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/) Reason for revert: Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.) Original issue's description: > Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) > > Reason for revert: > Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 > > InstallerStateTest.InitializeTwice (run #1): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) > > InstallerStateTest.InitializeTwice (run #2): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) > > > Original issue's description: > > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > > > Also don't use "default" as a variable name, as it's a keyword. > > Also fix a bug where a wstring was passed to %ls. > > > > No real behavior change. > > > > BUG=82385 > > R=hans@chromium.org > > TBR=cpu, vitalybuka > > > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 > > TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=82385 > > Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Committed: https://crrev.com/beb9fd30c68dd27606de80a2d017cddeeb799c3b Cr-Commit-Position: refs/heads/master@{#292818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M chrome/installer/gcapi/gcapi.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/x_privet_token.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M rlz/win/lib/machine_deal_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/fs.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests.
6 years, 3 months ago (2014-08-31 17:42:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/525013003/1
6 years, 3 months ago (2014-08-31 17:43:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as dff7c02ef803845ba05e94bd64b771f070767d01
6 years, 3 months ago (2014-08-31 17:45:31 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/beb9fd30c68dd27606de80a2d017cddeeb799c3b
Cr-Commit-Position: refs/heads/master@{#292818}

Powered by Google App Engine
This is Rietveld 408576698