Suppress promotional line and image on non-English builds of Chrome....

Suppress promotional image on non-English builds of Chrome, change message to promote sync only.

BUG=30814, 31565
TEST= Run a non-English Chrome build. Puzzle piece should not appear; promo line should only promote bookmark sync.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35506

[Miranda Callahan, 2010-01-04 22:17:22]

Two items:

1) This CL will fail on the try servers, because ToT and 249 differ in how they
generate the CSS for the NTP.

2) In non-English locales, the promo for sync is removed along with the
extensions promo, because it's bound into the same sentence and would require a
grd change and set of new translations in order to be pulled apart into a
separate message.

[Miranda Callahan, 2010-01-05 00:41:37]

Just in: going to change the promo for non-EN locales to "Synchronize my
bookmarks...", pulled from the already-translated messages in
generated_resources.grd.  Please don't review yet, thanks!

[Miranda Callahan, 2010-01-05 01:50:26]

Aaron, this CL is now fixed and ready to review.

[Aaron Boodman, 2010-01-05 02:01:19]

lgtm

http://codereview.chromium.org/525013/diff/4003/4005
File chrome/browser/dom_ui/new_tab_ui.cc (right):

http://codereview.chromium.org/525013/diff/4003/4005#newcode922
chrome/browser/dom_ui/new_tab_ui.cc:922: "en", false)) {
It is nice to add an inline comment explaining the meaning of boolean params.

http://codereview.chromium.org/525013/diff/4003/4005#newcode932
chrome/browser/dom_ui/new_tab_ui.cc:932:
l10n_util::GetString(IDS_SYNC_START_SYNC_BUTTON_LABEL) +
Cute hack.

[Miranda Callahan, 2010-01-05 02:05:14]

http://codereview.chromium.org/525013/diff/4003/4005
File chrome/browser/dom_ui/new_tab_ui.cc (right):

http://codereview.chromium.org/525013/diff/4003/4005#newcode922
chrome/browser/dom_ui/new_tab_ui.cc:922: "en", false)) {
On 2010/01/05 02:01:19, Aaron Boodman wrote:
> It is nice to add an inline comment explaining the meaning of boolean params.

Done.

http://codereview.chromium.org/525013/diff/4003/4005#newcode932
chrome/browser/dom_ui/new_tab_ui.cc:932:
l10n_util::GetString(IDS_SYNC_START_SYNC_BUTTON_LABEL) +
On 2010/01/05 02:01:19, Aaron Boodman wrote:
> Cute hack.

;-)