Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 525013: Suppress promotional line and image on non-English builds of Chrome.... (Closed)

Created:
10 years, 11 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Suppress promotional image on non-English builds of Chrome, change message to promote sync only. BUG=30814, 31565 TEST= Run a non-English Chrome build. Puzzle piece should not appear; promo line should only promote bookmark sync. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35506

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 4

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 2 3 4 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Miranda Callahan
Two items: 1) This CL will fail on the try servers, because ToT and 249 ...
10 years, 11 months ago (2010-01-04 22:17:22 UTC) #1
Miranda Callahan
Just in: going to change the promo for non-EN locales to "Synchronize my bookmarks...", pulled ...
10 years, 11 months ago (2010-01-05 00:41:37 UTC) #2
Miranda Callahan
Aaron, this CL is now fixed and ready to review.
10 years, 11 months ago (2010-01-05 01:50:26 UTC) #3
Aaron Boodman
lgtm http://codereview.chromium.org/525013/diff/4003/4005 File chrome/browser/dom_ui/new_tab_ui.cc (right): http://codereview.chromium.org/525013/diff/4003/4005#newcode922 chrome/browser/dom_ui/new_tab_ui.cc:922: "en", false)) { It is nice to add ...
10 years, 11 months ago (2010-01-05 02:01:19 UTC) #4
Miranda Callahan
10 years, 11 months ago (2010-01-05 02:05:14 UTC) #5
http://codereview.chromium.org/525013/diff/4003/4005
File chrome/browser/dom_ui/new_tab_ui.cc (right):

http://codereview.chromium.org/525013/diff/4003/4005#newcode922
chrome/browser/dom_ui/new_tab_ui.cc:922: "en", false)) {
On 2010/01/05 02:01:19, Aaron Boodman wrote:
> It is nice to add an inline comment explaining the meaning of boolean params.

Done.

http://codereview.chromium.org/525013/diff/4003/4005#newcode932
chrome/browser/dom_ui/new_tab_ui.cc:932:
l10n_util::GetString(IDS_SYNC_START_SYNC_BUTTON_LABEL) +
On 2010/01/05 02:01:19, Aaron Boodman wrote:
> Cute hack.

;-)

Powered by Google App Engine
This is Rietveld 408576698