Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: net/quic/quic_stream_factory.cc

Issue 524463004: Adds plumbing for always requiring handshake confirmation in QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory.h ('k') | net/quic/quic_stream_factory_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory.cc
diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc
index 003d17fd2cd8a87dfc828b3c794149f1674d5441..35c695563b1631ddd1a36fc871d611a5f3a7016d 100644
--- a/net/quic/quic_stream_factory.cc
+++ b/net/quic/quic_stream_factory.cc
@@ -481,6 +481,7 @@ QuicStreamFactory::QuicStreamFactory(
const QuicVersionVector& supported_versions,
bool enable_port_selection,
bool enable_time_based_loss_detection,
+ bool always_require_handshake_confirmation,
const QuicTagVector& connection_options)
: require_confirmation_(true),
host_resolver_(host_resolver),
@@ -496,6 +497,8 @@ QuicStreamFactory::QuicStreamFactory(
connection_options)),
supported_versions_(supported_versions),
enable_port_selection_(enable_port_selection),
+ always_require_handshake_confirmation_(
+ always_require_handshake_confirmation),
port_seed_(random_generator_->RandUint64()),
weak_factory_(this) {
DCHECK(transport_security_state_);
@@ -599,7 +602,8 @@ bool QuicStreamFactory::OnResolution(
void QuicStreamFactory::OnJobComplete(Job* job, int rv) {
if (rv == OK) {
- require_confirmation_ = false;
+ if (!always_require_handshake_confirmation_)
+ require_confirmation_ = false;
// Create all the streams, but do not notify them yet.
for (RequestSet::iterator it = job_requests_map_[job].begin();
« no previous file with comments | « net/quic/quic_stream_factory.h ('k') | net/quic/quic_stream_factory_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698