Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 524463004: Adds plumbing for always requiring handshake confirmation in QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index 82ec1cd5e418eca4b52ffd0595db8d8cacbcef44..76501847436fecdb8c5f8e85383b9baaa7132688 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -93,15 +93,25 @@ class QuicStreamFactoryTest : public ::testing::TestWithParam<QuicVersion> {
clock_(new MockClock()),
maker_(GetParam(), 0, clock_),
cert_verifier_(CertVerifier::CreateDefault()),
- channel_id_service_(new ChannelIDService(
- new DefaultChannelIDStore(NULL),
- base::MessageLoopProxy::current())),
- factory_(&host_resolver_, &socket_factory_,
- base::WeakPtr<HttpServerProperties>(), cert_verifier_.get(),
- channel_id_service_.get(), &transport_security_state_,
- &crypto_client_stream_factory_, &random_generator_, clock_,
- kDefaultMaxPacketSize, std::string(),
- SupportedVersions(GetParam()), true, true, QuicTagVector()),
+ channel_id_service_(
+ new ChannelIDService(new DefaultChannelIDStore(NULL),
+ base::MessageLoopProxy::current())),
+ factory_(&host_resolver_,
+ &socket_factory_,
+ base::WeakPtr<HttpServerProperties>(),
+ cert_verifier_.get(),
+ channel_id_service_.get(),
+ &transport_security_state_,
+ &crypto_client_stream_factory_,
+ &random_generator_,
+ clock_,
+ kDefaultMaxPacketSize,
+ std::string(),
+ SupportedVersions(GetParam()),
+ /*enable_port_selection=*/true,
+ /*enable_time_based_loss_detection=*/true,
+ /*always_require_handshake_confirmation=*/true,
+ QuicTagVector()),
host_port_pair_(kDefaultServerHostName, kDefaultServerPort),
is_https_(false),
privacy_mode_(PRIVACY_MODE_DISABLED) {
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698