Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 524353002: Remove the unused remnants of NPObject from Pepper (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the unused remnants of NPObject from Pepper BUG=351636 Committed: https://crrev.com/a9d77326214844389f8aef8ce4757506be33ddd1 Cr-Commit-Position: refs/heads/master@{#293844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -749 lines) Patch
M content/renderer/pepper/host_var_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/pepper/npapi_glue.h View 1 chunk +0 lines, -262 lines 0 comments Download
D content/renderer/pepper/npapi_glue.cc View 1 chunk +0 lines, -358 lines 0 comments Download
D content/renderer/pepper/npobject_var.h View 1 chunk +0 lines, -71 lines 0 comments Download
D content/renderer/pepper/npobject_var.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M content/renderer/pepper/v8object_var.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/var.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/shared_impl/var.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
raymes
6 years, 3 months ago (2014-09-01 05:45:01 UTC) #2
Sam McNally
lgtm
6 years, 3 months ago (2014-09-01 06:02:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/524353002/1
6 years, 3 months ago (2014-09-01 06:03:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/524353002/1
6 years, 3 months ago (2014-09-02 04:33:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/524353002/1
6 years, 3 months ago (2014-09-09 03:41:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 07eb94acb9410ef590bfe13383c4e6e0f95c4818
6 years, 3 months ago (2014-09-09 03:48:32 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:50:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9d77326214844389f8aef8ce4757506be33ddd1
Cr-Commit-Position: refs/heads/master@{#293844}

Powered by Google App Engine
This is Rietveld 408576698