Adds "Delete Local Storage" option to "Clear Browsing Data" for Windows and G...

Adds "Delete Local Storage" option to "Clear Browsing Data" for Windows and GTK.
NOTE: This change does not contain src/chrome/app/nibs/ClearBrowsingData.xib. It'll be edited by someone who knows about Mac.

BUG=none
TEST=The clear browser data dialog box should have a new option: Delete local storage"

[jorlow, 2010-01-05 01:47:18]

LGTM

Jens, can you finish this one up?

[Peter Kasting, 2010-01-05 01:50:04]

Can you add BUG= and TEST=?

In particular, I'm hoping to link to a bug where it is obvious what the UI
team's input on this was.  (I'm not trying to derail the patch here, I just want
to make sure we've closed the loop correctly.)

[jorlow, 2010-01-05 01:57:05]

Good point.  I'm not sure they've ever "officially" signed off on this.  Adding
beng/glen to the review.

Also there is no bug, though I should have created one when we did the original
hack (clearing cookies clears local storage) now that I think about it.

[Jens Alfke, 2010-01-07 00:28:14]

I've got the patch checked out and will work on the xib now.

[bulach_, 2010-01-07 00:31:22]

thanks Jens!

give us a shout if you need anything..

On Wed, Jan 6, 2010 at 4:28 PM,  <snej@chromium.org> wrote:
> I've got the patch checked out and will work on the xib now.
>
> http://codereview.chromium.org/524026
>

[jorlow, 2010-01-09 03:02:59]

+ brian who, in another thread, Brian OK'ed the approach in this review. 
(Adding one check box for delete local storage.)

[jorlow, 2010-01-09 03:07:03]

LGTM

Add the following to your description:
"""
BUG=none
TEST=The clear browser data dialog box should have a new option: Delete local
storage"
"""

I'll land on Monday.

[jorlow, 2010-01-11 23:41:06]

mostly LGTM

though a bunch of the code style kinda makes me cringe (really long, multi-line
statements) but I only commented when I had a concrete idea of how it might be
better

Dumi: please take a look at the cookie tree view part of it since you know a lot
more about that than I do at this point

[bulach_, 2010-01-13 04:24:55]

Hi Jeremy,

I sync'd, compiled and uploaded a new patchset, let me know if everything is
fine.

Thanks,
Marcus

On 2010/01/11 23:41:06, Jeremy Orlow wrote:
> mostly LGTM
> 
> though a bunch of the code style kinda makes me cringe (really long,
multi-line
> statements) but I only commented when I had a concrete idea of how it might be
> better
> 
> Dumi: please take a look at the cookie tree view part of it since you know a
lot
> more about that than I do at this point

[jorlow, 2010-01-13 05:06:32]

Landed in http://src.chromium.org/viewvc/chrome?view=rev&revision=36098

Please close this review manually.

[bulach_, 2010-01-13 05:20:14]

Thanks Jeremy!
Closed the issue.

On Tue, Jan 12, 2010 at 9:06 PM,  <jorlow@chromium.org> wrote:
> Landed in http://src.chromium.org/viewvc/chrome?view=rev&revision=36098
>
> Please close this review manually.
>
> http://codereview.chromium.org/524026
>