Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm

Issue 524026: Adds "Delete Local Storage" option to "Clear Browsing Data" for Windows and G... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/scoped_nsobject.h" 7 #include "base/scoped_nsobject.h"
8 #include "chrome/browser/browsing_data_remover.h" 8 #include "chrome/browser/browsing_data_remover.h"
9 #include "chrome/browser/cocoa/browser_test_helper.h" 9 #include "chrome/browser/cocoa/browser_test_helper.h"
10 #import "chrome/browser/cocoa/clear_browsing_data_controller.h" 10 #import "chrome/browser/cocoa/clear_browsing_data_controller.h"
11 #import "chrome/browser/cocoa/cocoa_test_helper.h" 11 #import "chrome/browser/cocoa/cocoa_test_helper.h"
12 #include "chrome/browser/profile.h" 12 #include "chrome/browser/profile.h"
13 #include "chrome/common/pref_names.h" 13 #include "chrome/common/pref_names.h"
14 #include "chrome/common/pref_service.h" 14 #include "chrome/common/pref_service.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 #include "testing/platform_test.h" 16 #include "testing/platform_test.h"
17 17
18 namespace { 18 namespace {
19 19
20 class ClearBrowsingDataControllerTest : public CocoaTest { 20 class ClearBrowsingDataControllerTest : public CocoaTest {
21 public: 21 public:
22 virtual void SetUp() { 22 virtual void SetUp() {
23 CocoaTest::SetUp(); 23 CocoaTest::SetUp();
24 // Set up some interesting prefs: 24 // Set up some interesting prefs:
25 PrefService* prefs = helper_.profile()->GetPrefs(); 25 PrefService* prefs = helper_.profile()->GetPrefs();
26 prefs->SetBoolean(prefs::kDeleteBrowsingHistory, true); 26 prefs->SetBoolean(prefs::kDeleteBrowsingHistory, true);
27 prefs->SetBoolean(prefs::kDeleteDownloadHistory, false); 27 prefs->SetBoolean(prefs::kDeleteDownloadHistory, false);
28 prefs->SetBoolean(prefs::kDeleteCache, true); 28 prefs->SetBoolean(prefs::kDeleteCache, true);
29 prefs->SetBoolean(prefs::kDeleteLocalStorage, true);
29 prefs->SetBoolean(prefs::kDeleteCookies, false); 30 prefs->SetBoolean(prefs::kDeleteCookies, false);
30 prefs->SetBoolean(prefs::kDeletePasswords, true); 31 prefs->SetBoolean(prefs::kDeletePasswords, true);
31 prefs->SetBoolean(prefs::kDeleteFormData, false); 32 prefs->SetBoolean(prefs::kDeleteFormData, false);
32 prefs->SetInteger(prefs::kDeleteTimePeriod, 33 prefs->SetInteger(prefs::kDeleteTimePeriod,
33 BrowsingDataRemover::FOUR_WEEKS); 34 BrowsingDataRemover::FOUR_WEEKS);
34 controller_ = 35 controller_ =
35 [ClearBrowsingDataController controllerForProfile:helper_.profile()]; 36 [ClearBrowsingDataController controllerForProfile:helper_.profile()];
36 } 37 }
37 38
38 virtual void TearDown() { 39 virtual void TearDown() {
39 [controller_ closeDialog]; 40 [controller_ closeDialog];
40 CocoaTest::TearDown(); 41 CocoaTest::TearDown();
41 } 42 }
42 43
43 BrowserTestHelper helper_; 44 BrowserTestHelper helper_;
44 ClearBrowsingDataController* controller_; 45 ClearBrowsingDataController* controller_;
45 }; 46 };
46 47
47 TEST_F(ClearBrowsingDataControllerTest, InitialState) { 48 TEST_F(ClearBrowsingDataControllerTest, InitialState) {
48 // Check properties match the prefs set above: 49 // Check properties match the prefs set above:
49 EXPECT_TRUE([controller_ clearBrowsingHistory]); 50 EXPECT_TRUE([controller_ clearBrowsingHistory]);
50 EXPECT_FALSE([controller_ clearDownloadHistory]); 51 EXPECT_FALSE([controller_ clearDownloadHistory]);
51 EXPECT_TRUE([controller_ emptyCache]); 52 EXPECT_TRUE([controller_ emptyCache]);
53 EXPECT_TRUE([controller_ deleteLocalStorage]);
52 EXPECT_FALSE([controller_ deleteCookies]); 54 EXPECT_FALSE([controller_ deleteCookies]);
53 EXPECT_TRUE([controller_ clearSavedPasswords]); 55 EXPECT_TRUE([controller_ clearSavedPasswords]);
54 EXPECT_FALSE([controller_ clearFormData]); 56 EXPECT_FALSE([controller_ clearFormData]);
55 EXPECT_EQ(BrowsingDataRemover::FOUR_WEEKS, 57 EXPECT_EQ(BrowsingDataRemover::FOUR_WEEKS,
56 [controller_ timePeriod]); 58 [controller_ timePeriod]);
57 } 59 }
58 60
59 TEST_F(ClearBrowsingDataControllerTest, InitialRemoveMask) { 61 TEST_F(ClearBrowsingDataControllerTest, InitialRemoveMask) {
60 // Check that the remove-mask matches the initial properties: 62 // Check that the remove-mask matches the initial properties:
61 EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY | 63 EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY |
62 BrowsingDataRemover::REMOVE_CACHE | 64 BrowsingDataRemover::REMOVE_CACHE |
65 BrowsingDataRemover::REMOVE_LOCAL_STORAGE |
63 BrowsingDataRemover::REMOVE_PASSWORDS, 66 BrowsingDataRemover::REMOVE_PASSWORDS,
64 [controller_ removeMask]); 67 [controller_ removeMask]);
65 } 68 }
66 69
67 TEST_F(ClearBrowsingDataControllerTest, ModifiedRemoveMask) { 70 TEST_F(ClearBrowsingDataControllerTest, ModifiedRemoveMask) {
68 // Invert all properties and check that the remove-mask is still correct: 71 // Invert all properties and check that the remove-mask is still correct:
69 [controller_ setClearBrowsingHistory:false]; 72 [controller_ setClearBrowsingHistory:false];
70 [controller_ setClearDownloadHistory:true]; 73 [controller_ setClearDownloadHistory:true];
71 [controller_ setEmptyCache:false]; 74 [controller_ setEmptyCache:false];
75 [controller_ setDeleteLocalStorage:false];
72 [controller_ setDeleteCookies:true]; 76 [controller_ setDeleteCookies:true];
73 [controller_ setClearSavedPasswords:false]; 77 [controller_ setClearSavedPasswords:false];
74 [controller_ setClearFormData:true]; 78 [controller_ setClearFormData:true];
75 79
76 EXPECT_EQ(BrowsingDataRemover::REMOVE_DOWNLOADS | 80 EXPECT_EQ(BrowsingDataRemover::REMOVE_DOWNLOADS |
77 BrowsingDataRemover::REMOVE_COOKIES | 81 BrowsingDataRemover::REMOVE_COOKIES |
78 BrowsingDataRemover::REMOVE_FORM_DATA, 82 BrowsingDataRemover::REMOVE_FORM_DATA,
79 [controller_ removeMask]); 83 [controller_ removeMask]);
80 } 84 }
81 85
82 TEST_F(ClearBrowsingDataControllerTest, EmptyRemoveMask) { 86 TEST_F(ClearBrowsingDataControllerTest, EmptyRemoveMask) {
83 // Clear all properties and check that the remove-mask is zero: 87 // Clear all properties and check that the remove-mask is zero:
84 [controller_ setClearBrowsingHistory:false]; 88 [controller_ setClearBrowsingHistory:false];
85 [controller_ setClearDownloadHistory:false]; 89 [controller_ setClearDownloadHistory:false];
86 [controller_ setEmptyCache:false]; 90 [controller_ setEmptyCache:false];
91 [controller_ setDeleteLocalStorage:false];
87 [controller_ setDeleteCookies:false]; 92 [controller_ setDeleteCookies:false];
88 [controller_ setClearSavedPasswords:false]; 93 [controller_ setClearSavedPasswords:false];
89 [controller_ setClearFormData:false]; 94 [controller_ setClearFormData:false];
90 95
91 EXPECT_EQ(0, 96 EXPECT_EQ(0,
92 [controller_ removeMask]); 97 [controller_ removeMask]);
93 } 98 }
94 99
95 TEST_F(ClearBrowsingDataControllerTest, PersistToPrefs) { 100 TEST_F(ClearBrowsingDataControllerTest, PersistToPrefs) {
96 // Change some settings and store to prefs: 101 // Change some settings and store to prefs:
97 [controller_ setClearBrowsingHistory:false]; 102 [controller_ setClearBrowsingHistory:false];
98 [controller_ setClearDownloadHistory:true]; 103 [controller_ setClearDownloadHistory:true];
99 [controller_ persistToPrefs]; 104 [controller_ persistToPrefs];
100 105
101 // Test that the modified settings were stored to prefs: 106 // Test that the modified settings were stored to prefs:
102 PrefService* prefs = helper_.profile()->GetPrefs(); 107 PrefService* prefs = helper_.profile()->GetPrefs();
103 EXPECT_FALSE(prefs->GetBoolean(prefs::kDeleteBrowsingHistory)); 108 EXPECT_FALSE(prefs->GetBoolean(prefs::kDeleteBrowsingHistory));
104 EXPECT_TRUE(prefs->GetBoolean(prefs::kDeleteDownloadHistory)); 109 EXPECT_TRUE(prefs->GetBoolean(prefs::kDeleteDownloadHistory));
105 110
106 // Make sure the rest of the prefs didn't change: 111 // Make sure the rest of the prefs didn't change:
107 EXPECT_TRUE(prefs->GetBoolean(prefs::kDeleteCache)); 112 EXPECT_TRUE(prefs->GetBoolean(prefs::kDeleteCache));
113 EXPECT_TRUE(prefs->GetBoolean(prefs::kDeleteLocalStorage));
108 EXPECT_FALSE(prefs->GetBoolean(prefs::kDeleteCookies)); 114 EXPECT_FALSE(prefs->GetBoolean(prefs::kDeleteCookies));
109 EXPECT_TRUE(prefs->GetBoolean(prefs::kDeletePasswords)); 115 EXPECT_TRUE(prefs->GetBoolean(prefs::kDeletePasswords));
110 EXPECT_FALSE(prefs->GetBoolean(prefs::kDeleteFormData)); 116 EXPECT_FALSE(prefs->GetBoolean(prefs::kDeleteFormData));
111 EXPECT_EQ(BrowsingDataRemover::FOUR_WEEKS, 117 EXPECT_EQ(BrowsingDataRemover::FOUR_WEEKS,
112 prefs->GetInteger(prefs::kDeleteTimePeriod)); 118 prefs->GetInteger(prefs::kDeleteTimePeriod));
113 } 119 }
114 120
115 TEST_F(ClearBrowsingDataControllerTest, SameControllerForProfile) { 121 TEST_F(ClearBrowsingDataControllerTest, SameControllerForProfile) {
116 ClearBrowsingDataController* controller = 122 ClearBrowsingDataController* controller =
117 [ClearBrowsingDataController controllerForProfile:helper_.profile()]; 123 [ClearBrowsingDataController controllerForProfile:helper_.profile()];
118 EXPECT_EQ(controller_, controller); 124 EXPECT_EQ(controller_, controller);
119 } 125 }
120 126
121 } // namespace 127 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/clear_browsing_data_controller.mm ('k') | chrome/browser/gtk/clear_browsing_data_dialog_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698