Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 523763003: ABANDONED: linux: Avoid bitmaps for Cambria, Calibri, and Consolas. (Closed)

Created:
6 years, 3 months ago by Daniel Erat
Modified:
6 years, 3 months ago
CC:
chromium-reviews, msw, eae, behdad
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

linux: Avoid bitmaps for Cambria, Calibri, and Consolas. When antialiasing is enabled, avoid using embedded bitmaps for several common fonts. Blink appears to incorrectly scale the bitmaps, but it's unlikely that users with antialiasing enabled would want to see differently-rendered bitmap text at any sizes. Note that subpixel positioning appears to be disabled in Blink at sizes where embedded bitmaps are present even when the bitmaps aren't used. I think that this is likely to be a separate bug. BUG=408059

Patch Set 1 #

Patch Set 2 : fix strcasecmp() calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M ui/gfx/font_render_params_linux.cc View 1 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Daniel Erat
i've discussed this in more detail in http://crbug.com/408059#c25. i think that it's desirable to avoid ...
6 years, 3 months ago (2014-09-19 23:16:53 UTC) #2
bungeman-chromium
On 2014/09/19 23:16:53, Daniel Erat wrote: > i've discussed this in more detail in http://crbug.com/408059#c25. ...
6 years, 3 months ago (2014-09-22 14:43:35 UTC) #3
Daniel Erat
On 2014/09/22 14:43:35, bungeman2 wrote: > On 2014/09/19 23:16:53, Daniel Erat wrote: > > i've ...
6 years, 3 months ago (2014-09-22 14:59:41 UTC) #4
bungeman-chromium
6 years, 3 months ago (2014-09-22 20:28:30 UTC) #5
On 2014/09/22 14:59:41, Daniel Erat wrote:
> On 2014/09/22 14:43:35, bungeman2 wrote:
> > On 2014/09/19 23:16:53, Daniel Erat wrote:
> > > i've discussed this in more detail in http://crbug.com/408059#c25. i think
> > that
> > > it's desirable to avoid bitmaps for these fonts in general, but there are
> > still
> > > the mysteries of why the bitmaps are getting scaled and why subpixel
> > positioning
> > > is disabled at some sizes even when we don't use bitmaps (maybe skia
forces
> it
> > > off?).
> > 
> > This is obviously just a short-term hack which hides an actual issue, and I
> > would prefer we didn't do this. I'll take a look into this today and see
> what's
> > actually happening.
> 
> great, thanks!
> 
> i'm still skeptical that most users want to use bitmaps at all for these
fonts,
> since they won't match the rendering settings that we use at other sizes.

https://codereview.chromium.org/596513002 fixes the the underlying cause of the
motivation for this CL.

Powered by Google App Engine
This is Rietveld 408576698