Don't try to scale embedded bitmaps.

Don't try to scale embedded bitmaps.

If a font is bitmap only we need to scale a bitmap to obtain
the requested size if there isn't an exact match. If a font has
embedded bitmaps then these bitmaps should never be scaled by Skia.
Allow FreeType to do the scaling (as requested by the font).

BUG=chromium:408059
Committed: https://skia.googlesource.com/skia/+/a85511adc0173bd44ec18dd7f026ef191b2d683e

[bungeman-skia, 2014-09-22 18:48:22]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[bungeman-skia, 2014-09-22 18:48:23]

Trying to scale embedded bitmaps by an average of one pixel using incorrectly
scaled bounds is a bad idea. Don't do it.

[mtklein, 2014-09-22 18:50:42]

https://codereview.chromium.org/596513002/diff/1/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/596513002/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:1306: fScaleY && fFace->size->metrics.y_ppem)
First check is now obsolete?

[bungeman-skia, 2014-09-22 19:02:52]

https://codereview.chromium.org/596513002/diff/1/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/596513002/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:1306: fScaleY && fFace->size->metrics.y_ppem)
On 2014/09/22 18:50:42, mtklein wrote:
> First check is now obsolete?

Indeed it is. It makes more sense to say !FT_IS_SCALABLE(fFace) instead of
fFace->glyph->format == FT_GLYPH_FORMAT_BITMAP here in any event. Updated and
changed comment to reflect rationale.

[mtklein, 2014-09-22 19:07:55]

lgtm

http://weknowmemes.com/generator/meme/478869/

[bungeman-skia, 2014-09-22 19:09:44]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-09-22 19:09:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596513002/20001

[commit-bot: I haz the power, 2014-09-22 19:24:47]

Committed patchset #2 (id:20001) as a85511adc0173bd44ec18dd7f026ef191b2d683e