Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/hid/hid_service_unittest.cc

Issue 523743005: Fix HidService lifetime issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« device/core/device_client.cc ('K') | « device/hid/hid_service_linux.cc ('k') | extensions/browser/api/extensions_api_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_service_unittest.cc
diff --git a/device/hid/hid_service_unittest.cc b/device/hid/hid_service_unittest.cc
index a807579e74d44b0ca877fc910ee277a767852c62..e5f692b22f0b418f98dfb16dd7df5985f9ce77f9 100644
--- a/device/hid/hid_service_unittest.cc
+++ b/device/hid/hid_service_unittest.cc
@@ -13,17 +13,17 @@ namespace device {
TEST(HidServiceTest, Create) {
base::MessageLoopForIO message_loop;
- scoped_ptr<HidService> service(
- HidService::Create(message_loop.message_loop_proxy()));
+ HidService* service = HidService::GetInstance(
+ message_loop.message_loop_proxy());
ASSERT_TRUE(service);
-
+/*
Reilly Grant (use Gerrit) 2014/09/05 00:12:41 Left over from testing?
Ken Rockot(use gerrit already) 2014/09/05 00:15:49 HA HA. Done.
std::vector<HidDeviceInfo> devices;
service->GetDevices(&devices);
for (std::vector<HidDeviceInfo>::iterator it = devices.begin();
it != devices.end();
++it) {
ASSERT_TRUE(it->device_id != kInvalidHidDeviceId);
- }
+ }*/
}
} // namespace device
« device/core/device_client.cc ('K') | « device/hid/hid_service_linux.cc ('k') | extensions/browser/api/extensions_api_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698