Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2040)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/hid/hid_service_linux.cc

Issue 523743005: Fix HidService lifetime issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« device/core/device_client.cc ('K') | « device/hid/hid_service_linux.h ('k') | device/hid/hid_service_unittest.cc » ('j') | device/hid/hid_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_service_linux.cc
diff --git a/device/hid/hid_service_linux.cc b/device/hid/hid_service_linux.cc
index 8146c14b7d65441b83517ee92cac3b4c54b6d1a6..3fb27aa27d2475a3ca4957d910a827318d7c36ec 100644
--- a/device/hid/hid_service_linux.cc
+++ b/device/hid/hid_service_linux.cc
@@ -41,8 +41,8 @@ const char kHIDUnique[] = "HID_UNIQ";
} // namespace
HidServiceLinux::HidServiceLinux(
- scoped_refptr<base::MessageLoopProxy> ui_message_loop)
- : ui_message_loop_(ui_message_loop),
+ scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner)
+ : ui_task_runner_(ui_task_runner),
weak_factory_(this) {
DeviceMonitorLinux* monitor = DeviceMonitorLinux::GetInstance();
monitor->AddObserver(this);
@@ -132,7 +132,7 @@ void HidServiceLinux::OnDeviceAdded(udev_device* device) {
if (!client) {
return;
}
- ui_message_loop_->PostTask(
+ ui_task_runner_->PostTask(
FROM_HERE,
base::Bind(&chromeos::PermissionBrokerClient::RequestPathAccess,
base::Unretained(client),
« device/core/device_client.cc ('K') | « device/hid/hid_service_linux.h ('k') | device/hid/hid_service_unittest.cc » ('j') | device/hid/hid_service_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698