device/hid/hid_connection_unittest.cc - Issue 523743005: Fix HidService lifetime issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/hid/hid_connection_unittest.cc

Issue 523743005: Fix HidService lifetime issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/hid/hid_connection_unittest.cc

diff --git a/device/hid/hid_connection_unittest.cc b/device/hid/hid_connection_unittest.cc

index aade928171bd891d0dd40f5ae0c6d5c19aeb4534..064720f4c03d9ac2d8a5432bfce483b614d1eafb 100644

--- a/device/hid/hid_connection_unittest.cc

+++ b/device/hid/hid_connection_unittest.cc

@@ -73,7 +73,8 @@ class HidConnectionTest : public testing::Test {

if (!UsbTestGadget::IsTestEnabled()) return;

message_loop_.reset(new base::MessageLoopForIO());

- service_.reset(HidService::Create(message_loop_->message_loop_proxy()));

+ service_.reset(HidService::GetInstance(

+ message_loop_->message_loop_proxy()));

ASSERT_TRUE(service_);

test_gadget_ = UsbTestGadget::Claim();