Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 523573004: Moves the hotwording checkbox back to the 'Privacy' section. (Closed)

Created:
6 years, 3 months ago by kcarattini
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moves the hotwording checkbox back to the 'Privacy' section. The hotwording checkbox was moved from the 'Privacy' section of the settings page in https://codereview.chromium.org/382123004/ This cl moves it back to the 'Privacy' section and shows and hides the 'Voice' section according to the enable-experimental-hotwording flag. BUG=407893 Committed: https://crrev.com/fe89ad8cd4813812e45aac8275894aadfd9f24a0 Cr-Commit-Position: refs/heads/master@{#292857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/resources/options/browser_options.html View 2 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
kcarattini
bauerb@ please review for OWNERS approval in chrome/browser/resources
6 years, 3 months ago (2014-09-01 02:02:56 UTC) #2
Matt Giuca
So after this CL, the "enable Ok Google" checkbox will appear under Privacy but the ...
6 years, 3 months ago (2014-09-01 02:45:11 UTC) #3
kcarattini
So showHotwordAlwaysOnSection_ is called only when the flag enable-experimental-hotwording is enabled. Otherwise neither the 'Voice' ...
6 years, 3 months ago (2014-09-01 02:48:32 UTC) #4
Matt Giuca
OK lgtm.
6 years, 3 months ago (2014-09-01 02:53:49 UTC) #5
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-01 08:45:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kcarattini@chromium.org/523573004/1
6 years, 3 months ago (2014-09-01 09:37:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as de01c3aca1c2bf58430fba5641857c8617214279
6 years, 3 months ago (2014-09-01 10:32:28 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe89ad8cd4813812e45aac8275894aadfd9f24a0
Cr-Commit-Position: refs/heads/master@{#292857}

Powered by Google App Engine
This is Rietveld 408576698