Creates new 'settings' section, 'Voice'.

Creates new chrome:settings section, 'Voice'.

Moves hotwording checkbox to new 'Voice' section.

BUG=390086
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284301

[kcarattini, 2014-07-11 04:06:17]

jhawkins@chromium.org: Please review changes in

[Matt Giuca, 2014-07-11 04:09:55]

https://codereview.chromium.org/382123004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/382123004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:9840: +        <message
name="IDS_OPTIONS_VOICE_GROUP_NAME" desc="The title of the voice group">
I'm not sure what context the translators get when translating strings. It's
possible they'll just see:
"The title of the voice group" : "Voice"
which won't really explain the context (I realise that the other groups are
explained the same way here).

Maybe add "in the settings page" to give a bit of context.

https://codereview.chromium.org/382123004/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/382123004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/browser_options_handler.cc:199: static
OptionsStringResource resources[] = {
I'm not sure why this file is not formatted properly, but you should not
reformat the whole file in this CL. Can you undo these changes and just add your
changes in the style of the surrounding text?

[kcarattini, 2014-07-11 05:00:36]

https://codereview.chromium.org/382123004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/382123004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:9840: +        <message
name="IDS_OPTIONS_VOICE_GROUP_NAME" desc="The title of the voice group">
On 2014/07/11 04:09:55, Matt Giuca wrote:
> I'm not sure what context the translators get when translating strings. It's
> possible they'll just see:
> "The title of the voice group" : "Voice"
> which won't really explain the context (I realise that the other groups are
> explained the same way here).
> 
> Maybe add "in the settings page" to give a bit of context.

Done.

https://codereview.chromium.org/382123004/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/382123004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/browser_options_handler.cc:199: static
OptionsStringResource resources[] = {
On 2014/07/11 04:09:55, Matt Giuca wrote:
> I'm not sure why this file is not formatted properly, but you should not
> reformat the whole file in this CL. Can you undo these changes and just add
your
> changes in the style of the surrounding text?

Done.

[Matt Giuca, 2014-07-11 07:35:06]

lgtm

[James Hawkins, 2014-07-14 18:18:41]

Why isn't this option listed under the 'Search' heading?  Seems search related
to me.

[rpetterson, 2014-07-15 19:44:40]

On 2014/07/14 18:18:41, James Hawkins wrote:
> Why isn't this option listed under the 'Search' heading?  Seems search related
> to me.

I thought it was supposed to be moved under search as well . . . ?
Search->Voice->Hotword

[kcarattini, 2014-07-16 01:16:48]

On 2014/07/15 19:44:40, rpetterson OOO until Aug 3 wrote:
> On 2014/07/14 18:18:41, James Hawkins wrote:
> > Why isn't this option listed under the 'Search' heading?  Seems search
related
> > to me.
> 
> I thought it was supposed to be moved under search as well . . . ?
> Search->Voice->Hotword

Perhaps I misread the mocks (I will send a link offline). Are there other
examples of sub-sections currently on the settings page, or would this be the
first?

[James Hawkins, 2014-07-16 19:39:18]

https://codereview.chromium.org/382123004/diff/30001/chrome/browser/resources...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/382123004/diff/30001/chrome/browser/resources...
chrome/browser/resources/options/browser_options.html:162:
metric="Options_HotwordCheckbox" type="checkbox" dialog-pref>
nit: Indentation is 4 spaces, not attribute alignment.  Here and elsewhere.

[kcarattini, 2014-07-17 01:09:06]

https://codereview.chromium.org/382123004/diff/30001/chrome/browser/resources...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/382123004/diff/30001/chrome/browser/resources...
chrome/browser/resources/options/browser_options.html:162:
metric="Options_HotwordCheckbox" type="checkbox" dialog-pref>
On 2014/07/16 19:39:18, James Hawkins wrote:
> nit: Indentation is 4 spaces, not attribute alignment.  Here and elsewhere.

Done.

[James Hawkins, 2014-07-18 17:25:24]

lgtm

[kcarattini, 2014-07-18 23:58:06]

Thanks. I have verified with the UI folks that this should be a top level
section and not a subsection of 'Search'.

[kcarattini, 2014-07-18 23:58:13]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-07-19 00:00:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcarattini@chromium.org/382123004/50001

[commit-bot: I haz the power, 2014-07-19 03:08:25]

Change committed as 284301