Remove WinInet FTP code.

Remove WinInet FTP code.

TEST=none
BUG=25520
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35524

[Paweł Hajdan Jr., 2010-01-02 13:09:44]

I just checked and it seems the new FTP stack doesn't have open compatibility
bugs. I think we can safely remove the old code.

[eroman, 2010-01-04 19:14:27]

(1) Can you add BUG=25520

(2) Has security had a chance to sign-off on the new implementation?

(3) Can you rename url_request_new_ftp_job.cc" in a follow-up, to delete the
"new" from its name?

LGTM

[Paweł Hajdan Jr., 2010-01-04 19:40:24]

+cevans for security comments (I think we don't have outstanding bugs from the
security review)

eroman: yes, I plan to do the rename after that (will remember about svn mv).

[eroman, 2010-01-04 21:39:00]

LGTM then.

[wtc, 2010-01-04 21:49:01]

LGTM.  This is an important milestone.  Thanks!

Please see if you can remove these three files, too.
  net/base/wininet_util.cc
  net/base/wininet_util.h
  net/base/wininet_util_unittest.cc

I hope no new code depends on wininet_util.h.

Another cleanup you can do is to search for any
remaining <wininet.h> in our source tree and see if its
inclusions can be removed.  This is low priority.

[eroman, 2010-01-04 21:51:51]

I noticed that chrome frame has several wininet dependencies.

We should see how much can be removed in a following cleanup --
hopefully we can take wininet.dll out of the link section of
chrome.gyp alltogether, or at least make it chrome frame specific...

On Mon, Jan 4, 2010 at 1:49 PM,  <wtc@chromium.org> wrote:
> LGTM.  This is an important milestone.  Thanks!
>
> Please see if you can remove these three files, too.
>  net/base/wininet_util.cc
>  net/base/wininet_util.h
>  net/base/wininet_util_unittest.cc
>
> I hope no new code depends on wininet_util.h.
>
> Another cleanup you can do is to search for any
> remaining <wininet.h> in our source tree and see if its
> inclusions can be removed.  This is low priority.
>
> http://codereview.chromium.org/523034
>

[wtc, 2010-01-04 21:58:38]

eroman: You're right.  I added wininet_util.{h,cc},
so I'm more sure they can be removed (unless some new
code is using them).  I'm less sure that all
#include <wininet.h> can be removed.