content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java - Issue 522943003: [Android] Fix findbugs errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java

Issue 522943003: [Android] Fix findbugs errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed threading issues in HttpAuthDatabase constructor Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java ('k') | content/shell/android/java/src/org/chromium/content_shell/Shell.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java b/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java

index b6ff368f8f097063dda3eb9a85ff3e6a77f68831..7b1f8ee9fa7336326477eb1ee2c6998adc390446 100644

--- a/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java

+++ b/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java

@@ -8,6 +8,7 @@ import android.os.AsyncTask;

import android.os.Bundle;

import android.util.Log;

+import java.io.IOException;

import java.security.GeneralSecurityException;

import java.security.Key;

import java.security.SecureRandom;

@@ -153,7 +154,10 @@ public class CipherFactory {

try {

seed = mRandomNumberProvider.getBytes(NUM_BYTES);

iv = mRandomNumberProvider.getBytes(NUM_BYTES);

- } catch (Exception e) {

+ } catch (IOException e) {

+ Log.e(TAG, "Couldn't get generator data.");

+ return null;

+ } catch (GeneralSecurityException e) {

Log.e(TAG, "Couldn't get generator data.");

return null;

}