android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java - Issue 522943003: [Android] Fix findbugs errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java

Issue 522943003: [Android] Fix findbugs errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed threading issues in HttpAuthDatabase constructor Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java ('k') | content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java

index ba4850ee98c12611bff52e3de8ccd74457637552..113fad3fa30d1fbec0c7f313ca82cdd9ba59fdb5 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java

@@ -32,7 +32,7 @@ public class HttpAuthDatabaseTest extends AndroidTestCase {

@SmallTest

@Feature({"AndroidWebView"})

public void testAccessHttpAuthUsernamePassword() throws Exception {

- HttpAuthDatabase instance = new HttpAuthDatabase(getContext(), TEST_DATABASE);

+ HttpAuthDatabase instance = HttpAuthDatabase.newInstance(getContext(), TEST_DATABASE);

String host = "http://localhost:8080";

String realm = "testrealm";