Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 522683003: Move basic string operations to ui/app_list/search (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move basic string operations to ui/app_list/search BUG=380875 R=xiyuan@chromium.org TEST=build succeeds Committed: https://crrev.com/1a85132a517b83b9b16c9433a0a65fc54b6ee5ec Cr-Commit-Position: refs/heads/master@{#292990}

Patch Set 1 #

Patch Set 2 : icu #

Patch Set 3 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1192 lines) Patch
M chrome/browser/ui/app_list/search/app_result.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/history.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/app_list/search/term_break_iterator.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/app_list/search/term_break_iterator.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/app_list/search/term_break_iterator_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string_char_iterator.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string_char_iterator.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string_char_iterator_unittest.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string_match.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string_match.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string_match_unittest.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/browser/ui/app_list/search/tokenized_string_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 2 4 chunks +14 lines, -1 line 0 comments Download
M ui/app_list/app_list.gyp View 1 3 chunks +13 lines, -0 lines 0 comments Download
A + ui/app_list/search/term_break_iterator.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + ui/app_list/search/term_break_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/app_list/search/term_break_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/app_list/search/tokenized_string.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + ui/app_list/search/tokenized_string.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/app_list/search/tokenized_string_char_iterator.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + ui/app_list/search/tokenized_string_char_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/app_list/search/tokenized_string_char_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/app_list/search/tokenized_string_match.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + ui/app_list/search/tokenized_string_match.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/app_list/search/tokenized_string_match_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + ui/app_list/search/tokenized_string_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Jun Mukai
6 years, 3 months ago (2014-08-29 20:47:44 UTC) #1
xiyuan
lgtm
6 years, 3 months ago (2014-08-29 20:57:54 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-30 03:53:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/11076)
6 years, 3 months ago (2014-08-30 04:00:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/522683003/20001
6 years, 3 months ago (2014-09-02 17:27:29 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-02 19:27:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/522683003/40001
6 years, 3 months ago (2014-09-02 19:34:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c1f2399f3ebbb37cb8c748c502486e11a1a8c2d7
6 years, 3 months ago (2014-09-02 20:36:22 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:32 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a85132a517b83b9b16c9433a0a65fc54b6ee5ec
Cr-Commit-Position: refs/heads/master@{#292990}

Powered by Google App Engine
This is Rietveld 408576698