chrome/browser/ui/app_list/search/history.cc - Issue 522683003: Move basic string operations to ui/app_list/search

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/app_list/search/history.cc

Issue 522683003: Move basic string operations to ui/app_list/search (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/app_list/search/history.h"	5 #include "chrome/browser/ui/app_list/search/history.h"

6	6

7 #include "base/files/file_path.h"	7 #include "base/files/file_path.h"

8 #include "base/strings/string_util.h"	8 #include "base/strings/string_util.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "chrome/browser/ui/app_list/search/history_data.h"	10 #include "chrome/browser/ui/app_list/search/history_data.h"

11 #include "chrome/browser/ui/app_list/search/history_data_store.h"	11 #include "chrome/browser/ui/app_list/search/history_data_store.h"

12 #include "chrome/browser/ui/app_list/search/tokenized_string.h"

13 #include "content/public/browser/browser_context.h"	12 #include "content/public/browser/browser_context.h"

	13 #include "ui/app_list/search/tokenized_string.h"

14	14

15 namespace app_list {	15 namespace app_list {

16	16

17 namespace {	17 namespace {

18	18

19 // Normalize the given string by joining all its tokens with a space.	19 // Normalize the given string by joining all its tokens with a space.

20 std::string NormalizeString(const std::string& utf8) {	20 std::string NormalizeString(const std::string& utf8) {

21 TokenizedString tokenized(base::UTF8ToUTF16(utf8));	21 TokenizedString tokenized(base::UTF8ToUTF16(utf8));

22 return base::UTF16ToUTF8(JoinString(tokenized.tokens(), ' '));	22 return base::UTF16ToUTF8(JoinString(tokenized.tokens(), ' '));

23 }	23 }

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 const std::string& query) const {	57 const std::string& query) const {

58 DCHECK(IsReady());	58 DCHECK(IsReady());

59 return data_->GetKnownResults(NormalizeString(query)).Pass();	59 return data_->GetKnownResults(NormalizeString(query)).Pass();

60 }	60 }

61	61

62 void History::OnHistoryDataLoadedFromStore() {	62 void History::OnHistoryDataLoadedFromStore() {

63 data_loaded_ = true;	63 data_loaded_ = true;

64 }	64 }

65	65

66 } // namespace app_list	66 } // namespace app_list

OLD	NEW