Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 522623002: Revert of Try backing SkPicture with SkRecord in Chromium. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Stephen White, robertphillips, Tom Hudson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #2 of https://codereview.chromium.org/504823003/) Reason for revert: This is breaking the following Blink test: inspector/layers/layer-canvas-log.html Original issue's description: > Try backing SkPicture with SkRecord in Chromium. > > This is our first attempt, mostly to feel this out. Performance and > correctness problems are both possible. Please revert this if a benchmark even > smells funny. > > That said, we've been working on this a while, are pretty confident it's good > stuff, and have had Skia's internal testing entirely switched over for a week. > Parts of Chromium that serialize and deserialize SkPictures are already > switched over. This CL finishes things off by switching the default > recorded-from-scratch SkPicture to use SkRecord too. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c > > Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30 TBR=reed@google.com,mtklein@google.com,senorblanco@chromium.org,eroman@chromium.org,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/fe5226eee8343a325c6b4d5d0e75f94c96c4616e Cr-Commit-Position: refs/heads/master@{#292598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M skia/config/SkUserConfig.h View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Try backing SkPicture with SkRecord in Chromium.
6 years, 3 months ago (2014-08-29 09:30:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/522623002/1
6 years, 3 months ago (2014-08-29 09:31:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as a2194cbb6f8a09cec7e78901b9016f00a0aa1ffb
6 years, 3 months ago (2014-08-29 09:31:35 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:07:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe5226eee8343a325c6b4d5d0e75f94c96c4616e
Cr-Commit-Position: refs/heads/master@{#292598}

Powered by Google App Engine
This is Rietveld 408576698