Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 522463002: Revert SetShape to dev channel & whitelist restricted. (Closed)

Created:
6 years, 3 months ago by Wez
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert SetShape to dev channel or whitelist. BUG=324071, 374440, 408737 Committed: https://crrev.com/ef97623cf0cacf08259c6733c457ff5fd85cc277 Cr-Commit-Position: refs/heads/master@{#292562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +50 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Wez
wez@chromium.org changed reviewers: + kalman@chromium.org
6 years, 3 months ago (2014-08-28 23:30:48 UTC) #1
Wez
PTAL This will be merged back to M38 and reverted once we've finalised a few ...
6 years, 3 months ago (2014-08-28 23:30:48 UTC) #2
garykac
On 2014/08/28 23:30:48, Wez wrote: > PTAL > > This will be merged back to ...
6 years, 3 months ago (2014-08-28 23:43:30 UTC) #3
not at google - send to devlin
Wah. Need more context.
6 years, 3 months ago (2014-08-28 23:47:53 UTC) #4
not at google - send to devlin
lgtm, thanks for the context.
6 years, 3 months ago (2014-08-29 00:20:08 UTC) #5
Wez
The CQ bit was checked by wez@chromium.org
6 years, 3 months ago (2014-08-29 00:20:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/522463002/1
6 years, 3 months ago (2014-08-29 00:21:53 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 02:14:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8f0e8cf9940747db8e852f949e1ba4589466caa0
6 years, 3 months ago (2014-08-29 03:19:05 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:05:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef97623cf0cacf08259c6733c457ff5fd85cc277
Cr-Commit-Position: refs/heads/master@{#292562}

Powered by Google App Engine
This is Rietveld 408576698