Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 453173002: Enable SetShape on stable channel. (Closed)

Created:
6 years, 4 months ago by garykac
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable SetShape on stable channel. The SetAlphaShape bugs have been fixed: * HiDPI Shape: crrev.com/394193003 * Null Shape: crrev.com/456943004 BUG=324071, 374440 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289147

Patch Set 1 #

Patch Set 2 : sync/merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -50 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 2 chunks +4 lines, -50 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
garykac
This can't land until crrev.com/456943004 lands, but I wanted to put it on your radar.
6 years, 4 months ago (2014-08-11 18:34:48 UTC) #1
not at google - send to devlin
thanks
6 years, 4 months ago (2014-08-11 19:33:26 UTC) #2
not at google - send to devlin
(ping when that CL has landed of course)
6 years, 4 months ago (2014-08-11 19:33:35 UTC) #3
garykac
On 2014/08/11 19:33:35, kalman wrote: > (ping when that CL has landed of course) crrev.com/456943004 ...
6 years, 4 months ago (2014-08-12 04:59:38 UTC) #4
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-12 20:09:45 UTC) #5
garykac
The CQ bit was checked by garykac@chromium.org
6 years, 4 months ago (2014-08-12 20:21:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/453173002/1
6 years, 4 months ago (2014-08-12 20:22:16 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 20:28:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 20:32:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/5095) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3732) ios_rel_device_ninja ...
6 years, 4 months ago (2014-08-12 20:32:16 UTC) #10
garykac
The CQ bit was checked by garykac@chromium.org
6 years, 4 months ago (2014-08-12 21:29:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/453173002/20001
6 years, 4 months ago (2014-08-12 21:37:32 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 01:21:16 UTC) #13
Message was sent while issue was closed.
Change committed as 289147

Powered by Google App Engine
This is Rietveld 408576698