Issue 52223002: Revert 231699 "Remove kNaturalScrollDefault."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52223002: Revert 231699 "Remove kNaturalScrollDefault." (Closed)

Created:
7 years, 1 month ago by kinaba

Modified:
7 years, 1 month ago

Reviewers:
achuithb

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 231699 "Remove kNaturalScrollDefault." Many tests started failing at ui::ShouldDefaultToNaturalScroll(), e.g., http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/26125/steps/unit_tests/logs/TestFocusNotification > Remove kNaturalScrollDefault. > > We have a runtime check - IsTouchDevicePresent, so just use that instead of the flag. > > BUG=NONE > TEST=manual > > Review URL: https://codereview.chromium.org/33913003 TBR=achuith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231779

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -5 lines)			Patch
M	trunk/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/chrome_restart_request.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/login_display_host_impl.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/preferences.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/chromeos/chromeos_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chromeos/chromeos_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r231779.