Issue 33913003: Remove kNaturalScrollDefault.

Issue 33913003: Remove kNaturalScrollDefault. (Closed)

Created:
7 years, 2 months ago by achuithb

Modified:
4 years, 7 months ago

Reviewers:
xiyuan, James Cook

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tfarina, davemoore+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove kNaturalScrollDefault. We have a runtime check - IsTouchDevicePresent, so just use that instead of the flag. BUG=NONE TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231699

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix rebase errors #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
M	chrome/browser/chromeos/login/ui/login_display_host_impl.cc	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View	1 2 3 4	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chromeos/chromeos_switches.h	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/chromeos_switches.cc	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/33913003/1

7 years, 2 months ago (2013-10-22 19:15:18 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31879

7 years, 2 months ago (2013-10-22 19:37:01 UTC) #4

achuithb

James, could you please take a look at tab_scrubber_browsertest.cc? I need an owner lgtm. Note ...

7 years, 2 months ago (2013-10-22 20:51:17 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/33913003/1

7 years, 2 months ago (2013-10-22 21:20:25 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/33913003/300001

7 years, 1 month ago (2013-10-29 18:40:34 UTC) #9

James Cook

On 2013/10/30 01:19:23, I haz the power (commit-bot) wrote: > Change committed as 231699 Can ...

6 years, 11 months ago (2014-01-17 16:43:28 UTC) #11

achuithb

On 2014/01/17 16:43:28, James Cook wrote: > On 2013/10/30 01:19:23, I haz the power (commit-bot) ...

6 years, 11 months ago (2014-01-17 21:24:25 UTC) #12

James Cook

On 2014/01/17 21:24:25, achuithb wrote: > On 2014/01/17 16:43:28, James Cook wrote: > > On ...

4 years, 7 months ago (2016-04-27 15:25:49 UTC) #13

achuithb

4 years, 7 months ago (2016-04-27 20:55:29 UTC) #14

Message was sent while issue was closed.

On 2016/04/27 15:25:49, James Cook wrote:
> On 2014/01/17 21:24:25, achuithb wrote:
> > On 2014/01/17 16:43:28, James Cook wrote:
> > > On 2013/10/30 01:19:23, I haz the power (commit-bot) wrote:
> > > > Change committed as 231699
> > > 
> > > Can I close this issue? It's landed, I don't know why this codereview is
> open.
> > 
> > No, I need to re-land this :( It got reverted because it was causing some
> > crashes on the bots. I think I was using ui::ShouldDefaultToNaturalScroll()
> too
> > early in the initialization sequence.
> 
> Can we close this review? It's been open for 2 years. :-)

Yup, I believe this code has already evolved beyond this. 

Good to have you back, btw :)

Expand Messages | Collapse Messages