bisect-builds.py: Fix broken chromium changelog URL to new URL.

bisect-builds.py: Fix broken chromium changelog URL to new URL.

BUG=None
NOTRY=True

Committed: https://crrev.com/9ce271f8ea373d7300392b5f186670384ffa105d
Cr-Commit-Position: refs/heads/master@{#293007}

[pshenoy, 2014-08-29 23:24:35]

pshenoy@chromium.org changed reviewers:
+ dalecurtis@chromium.org, rsesek@chromium.org

[DaleCurtis, 2014-08-29 23:33:34]

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:36: CRREV_URL = ('http://crrev.com/%s')
Hmm, this works, but is it the right way? Also for single replacement at the end
of the string just concatenate.

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:957: search_pattern = re.compile(GITHASH_SEARCH_PATTERN)
No point in compiling here. Compile globally if you want this.

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:960: return None
Automatically done, no need to write.

[pshenoy, 2014-08-29 23:53:38]

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:36: CRREV_URL = ('http://crrev.com/%s')
On 2014/08/29 23:33:34, DaleCurtis wrote:
> Hmm, this works, but is it the right way? Also for single replacement at the
end
> of the string just concatenate.

I'm not sure if there is any easy way to convert svn revision to githash without
having a local git checkout.

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:957: search_pattern = re.compile(GITHASH_SEARCH_PATTERN)
On 2014/08/29 23:33:34, DaleCurtis wrote:
> No point in compiling here. Compile globally if you want this.

Done.

https://codereview.chromium.org/521993002/diff/1/tools/bisect-builds.py#newco...
tools/bisect-builds.py:960: return None
On 2014/08/29 23:33:34, DaleCurtis wrote:
> Automatically done, no need to write.

Done.

[Robert Sesek, 2014-09-02 20:14:02]

LGTM

https://codereview.chromium.org/521993002/diff/20001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/521993002/diff/20001/tools/bisect-builds.py#n...
tools/bisect-builds.py:951: def PrintChangeLog(min_chromium_rev,
max_chromium_rev):
nit: another blank line before

https://codereview.chromium.org/521993002/diff/20001/tools/bisect-builds.py#n...
tools/bisect-builds.py:953: def GetGitHashFromSVNRevision(svn_revision):
naming: prefix with underscore

[pshenoy, 2014-09-02 20:34:02]

https://codereview.chromium.org/521993002/diff/20001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/521993002/diff/20001/tools/bisect-builds.py#n...
tools/bisect-builds.py:951: def PrintChangeLog(min_chromium_rev,
max_chromium_rev):
On 2014/09/02 20:14:01, rsesek wrote:
> nit: another blank line before

Done.

https://codereview.chromium.org/521993002/diff/20001/tools/bisect-builds.py#n...
tools/bisect-builds.py:953: def GetGitHashFromSVNRevision(svn_revision):
On 2014/09/02 20:14:01, rsesek wrote:
> naming: prefix with underscore

Done.

[pshenoy, 2014-09-02 20:38:13]

The CQ bit was checked by pshenoy@chromium.org

[commit-bot: I haz the power, 2014-09-02 20:41:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pshenoy@chromium.org/521993002/40001

[commit-bot: I haz the power, 2014-09-02 22:15:04]

Committed patchset #3 (id:40001) as c995f84a7d398c49efa93f3412a84434a5added3

[commit-bot: I haz the power, 2014-09-10 03:21:14]

Patchset 3 (id:??) landed as
https://crrev.com/9ce271f8ea373d7300392b5f186670384ffa105d
Cr-Commit-Position: refs/heads/master@{#293007}