bisect-builds.py: Fix broken chromium changelog URL to new URL.

tools/bisect-builds.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Snapshot Build Bisect Tool
 
 This script bisects a snapshot archive using binary search. It starts at
 a bad revision (it will try to guess HEAD) and asks for a last known-good
 revision. It will then binary search across this revision range by downloading,
@@ skipping 12 matching lines @@
 # GS bucket name.
 GS_BUCKET_NAME = 'chrome-unsigned/desktop-W15K3Y'
 
 # Base URL for downloading official builds.
 GOOGLE_APIS_URL = 'commondatastorage.googleapis.com'
 
 # The base URL for official builds.
 OFFICIAL_BASE_URL = 'http://%s/%s' % (GOOGLE_APIS_URL, GS_BUCKET_NAME)
 
 # URL template for viewing changelogs between revisions.
-CHANGELOG_URL = ('http://build.chromium.org'
-                 '/f/chromium/perf/dashboard/ui/changelog.html'
-                 '?url=/trunk/src&range=%d%%3A%d')
+CHANGELOG_URL = ('https://chromium.googlesource.com/chromium/src/+log/%s..%s')
+
+# URL to convert SVN revision to git hash.
+CRREV_URL = ('http://crrev.com/%s')

[DaleCurtis, 2014/08/29 23:33:34]

Hmm, this works, but is it the right way? Also for single replacement at the end
of the string just concatenate.

[pshenoy, 2014/08/29 23:53:38]

I'm not sure if there is any easy way to convert svn revision to githash without
having a local git checkout.

+
+# Search pattern to match git hash.
+GITHASH_SEARCH_PATTERN = (r'<title>(\w+)\s')
 
 # URL template for viewing changelogs between official versions.
 OFFICIAL_CHANGELOG_URL = ('https://chromium.googlesource.com/chromium/'
                           'src/+log/%s..%s?pretty=full')
 
 # DEPS file URL.
 DEPS_FILE = 'http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?revision=%d'
 
 # Blink changelogs URL.
 BLINK_CHANGELOG_URL = ('http://build.chromium.org'
@@ skipping 891 matching lines @@
   try:
     # Location of the latest build revision number
     latest_revision = urllib.urlopen(url).read()
     if latest_revision.isdigit():
       return int(latest_revision)
     return context.GetSVNRevisionFromGitHash(latest_revision)
   except Exception:
     print 'Could not determine latest revision. This could be bad...'
     return 999999999
 
+def PrintChangeLog(min_chromium_rev, max_chromium_rev):
+  """Prints the changelog URL."""
+  def GetGitHashFromSVNRevision(svn_revision):
+    crrev_url = CRREV_URL % str(svn_revision)
+    url = urllib.urlopen(crrev_url)
+    if url.getcode() == 200:
+      search_pattern = re.compile(GITHASH_SEARCH_PATTERN)

[DaleCurtis, 2014/08/29 23:33:34]

No point in compiling here. Compile globally if you want this.

[pshenoy, 2014/08/29 23:53:38]

Done.

+      result = search_pattern.search(url.read())
+      return result.group(1)
+    return None

[DaleCurtis, 2014/08/29 23:33:34]

Automatically done, no need to write.

[pshenoy, 2014/08/29 23:53:38]

Done.

+
+  print ('  ' + CHANGELOG_URL % (GetGitHashFromSVNRevision(min_chromium_rev),
+         GetGitHashFromSVNRevision(max_chromium_rev)))
+
 
 def main():
   usage = ('%prog [options] [-- chromium-options]\n'
            'Perform binary search on the snapshot builds to find a minimal\n'
            'range of revisions where a behavior change happened. The\n'
            'behaviors are described as "good" and "bad".\n'
            'It is NOT assumed that the behavior of the later revision is\n'
            'the bad one.\n'
            '\n'
            'Revision numbers should use\n'
@@ skipping 183 matching lines @@
       print DONE_MESSAGE_GOOD_MIN % (str(min_chromium_rev),
                                      str(max_chromium_rev))
     if min_blink_rev != max_blink_rev:
       print ('NOTE: There is a Blink roll in the range, '
              'you might also want to do a Blink bisect.')
 
     print 'CHANGELOG URL:'
     if opts.official_builds:
       print OFFICIAL_CHANGELOG_URL % (min_chromium_rev, max_chromium_rev)
     else:
-      print '  ' + CHANGELOG_URL % (min_chromium_rev, max_chromium_rev)
+      PrintChangeLog(min_chromium_rev, max_chromium_rev)
 
 
 if __name__ == '__main__':
   sys.exit(main())