Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 521953002: Do not show irrelevant registration promos to supervised and guest users (Closed)

Created:
6 years, 3 months ago by Noam Samuel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not show irrelevant registration promos to supervised and guest users Hide registration promos for supervised and guest users. Also hide cloud print connector section and irrelevant "cloud devices" section (since users cannot log in). BUG=288614, 340893 Committed: https://crrev.com/00b31698ea813d2769d7a4f0f0442db203571b07 Cr-Commit-Position: refs/heads/master@{#292806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M chrome/browser/resources/local_discovery/local_discovery.html View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 3 chunks +23 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Noam Samuel
6 years, 3 months ago (2014-08-29 22:42:54 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-08-30 19:43:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/521953002/1
6 years, 3 months ago (2014-08-30 19:43:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9b6fc6af95d151b70e06f90c19af4e8da0ebba4e
6 years, 3 months ago (2014-08-30 20:42:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00b31698ea813d2769d7a4f0f0442db203571b07
Cr-Commit-Position: refs/heads/master@{#292806}

Powered by Google App Engine
This is Rietveld 408576698