Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6437)

Unified Diff: chrome/browser/resources/local_discovery/local_discovery.js

Issue 521953002: Do not show irrelevant registration promos to supervised and guest users (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_discovery/local_discovery.js
diff --git a/chrome/browser/resources/local_discovery/local_discovery.js b/chrome/browser/resources/local_discovery/local_discovery.js
index 68fe480bcc969ce2912184c8be9cef2d1a8f10f6..60f8c00b6bfa2acc5d8ef6747bd74e8d52af382a 100644
--- a/chrome/browser/resources/local_discovery/local_discovery.js
+++ b/chrome/browser/resources/local_discovery/local_discovery.js
@@ -46,6 +46,12 @@ cr.define('local_discovery', function() {
var isUserLoggedIn = true;
/**
+ * Whether or not the user is supervised or off the record.
+ * @type bool
+ */
+ var isUserSupervisedOrOffTheRecord = false;
+
+ /**
* Whether or not the path-based dialog has been shown.
* @type bool
*/
@@ -407,7 +413,8 @@ cr.define('local_discovery', function() {
$('register-login-promo').hidden = true;
} else {
$('no-printers-message').hidden = true;
- $('register-login-promo').hidden = isUserLoggedIn;
+ $('register-login-promo').hidden = isUserLoggedIn ||
+ isUserSupervisedOrOffTheRecord;
}
}
@@ -506,14 +513,24 @@ cr.define('local_discovery', function() {
/**
* User is not logged in.
*/
- function setUserLoggedIn(userLoggedIn) {
+ function setUserLoggedIn(userLoggedIn, userSupervisedOrOffTheRecord) {
isUserLoggedIn = userLoggedIn;
+ isUserSupervisedOrOffTheRecord = userSupervisedOrOffTheRecord;
- $('cloud-devices-login-promo').hidden = isUserLoggedIn;
- $('register-overlay-login-promo').hidden = isUserLoggedIn;
- $('register-continue-button').disabled = !isUserLoggedIn;
+ $('cloud-devices-login-promo').hidden = isUserLoggedIn ||
+ isUserSupervisedOrOffTheRecord;
+ $('register-overlay-login-promo').hidden = isUserLoggedIn ||
+ isUserSupervisedOrOffTheRecord;
+ $('register-continue-button').disabled = !isUserLoggedIn ||
+ isUserSupervisedOrOffTheRecord;
- if (isUserLoggedIn) {
+ $('my-devices-container').hidden = userSupervisedOrOffTheRecord;
+
+ if (isUserSupervisedOrOffTheRecord) {
+ $('cloud-print-connector-section').hidden = true;
+ }
+
+ if (isUserLoggedIn && !isUserSupervisedOrOffTheRecord) {
requestDeviceList();
$('register-login-promo').hidden = true;
} else {

Powered by Google App Engine
This is Rietveld 408576698