Issue 521643003: Fixed a11y tab handling on cookies settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521643003: Fixed a11y tab handling on cookies settings (Closed)

Created:
6 years, 3 months ago by hcarmona

Modified:
6 years, 3 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixed a11y tab handling on cookies settings Hidden buttons are no longer accessible by pressing TAB. Cookie buttons are no longer accessible by pressing TAB. The cookie buttons are still accessible by pressing left/right. The "Remove" button is still accessible by pressing TAB. BUG=408470 Committed: https://crrev.com/71723cbdf0f1d15ec88f59d1ceb423673ebdef6a Cr-Commit-Position: refs/heads/master@{#292770}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/cookies_list.js	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/resources/options/cookies_view.css	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Committed patchset #1 (id:1) as 08267c852b012cc516e6f10c183d1354cdd700a7

6 years, 3 months ago (2014-08-30 05:11:39 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:13:41 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/71723cbdf0f1d15ec88f59d1ceb423673ebdef6a
Cr-Commit-Position: refs/heads/master@{#292770}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages