chrome/browser/resources/options/cookies_list.js - Issue 521643003: Fixed a11y tab handling on cookies settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/cookies_list.js

Issue 521643003: Fixed a11y tab handling on cookies settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/cookies_list.js

diff --git a/chrome/browser/resources/options/cookies_list.js b/chrome/browser/resources/options/cookies_list.js

index 0d7d5f480d4c98edf08b76b26ebdd55afa316af4..29159c4f1a969262787a511283f52e545d0d0dc7 100644

--- a/chrome/browser/resources/options/cookies_list.js

+++ b/chrome/browser/resources/options/cookies_list.js

@@ -173,12 +173,12 @@ cr.define('options', function() {

return;

this.expanded_ = expanded;

if (expanded) {

+ this.classList.add('show-items');

var oldExpanded = this.list.expandedItem;

this.list.expandedItem = this;

this.updateItems_();

if (oldExpanded)

oldExpanded.expanded = false;

- this.classList.add('show-items');

} else {

if (this.list.expandedItem == this) {

this.list.expandedItem = null;

@@ -535,7 +535,6 @@ cr.define('options', function() {

div.className = 'cookie-item';

// Help out screen readers and such: this is a clickable thing.

div.setAttribute('role', 'button');

- div.tabIndex = 0;

div.textContent = text;

var apps = this.data.appsProtectingThis;

if (apps)

« no previous file with comments | « no previous file | chrome/browser/resources/options/cookies_view.css » ('j') | no next file with comments »