Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 521613002: Pass more frame timing information to Blink (Closed)

Created:
6 years, 3 months ago by Sami
Modified:
6 years, 3 months ago
Reviewers:
jamesr, picksi1
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, picksi1, alex clarke (OOO till 29th)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pass more frame timing information to Blink This patch conveys more information about frame timings to Blink. Specifically it adds the current deadline by which work should be finished as well as the expected interval between frames. The Blink scheduler will use this information to schedule lower priority work. We also notify Blink when a committed frame actually got composited, which means the current frame is done and lower priority work can be started immediately (i.e., before the scheduled deadline). BUG=391005 Committed: https://crrev.com/7759d7aef4c97d3454c15607945e23595c2dfa3e Cr-Commit-Position: refs/heads/master@{#293476}

Patch Set 1 #

Patch Set 2 : Add more frame timings. #

Total comments: 2

Patch Set 3 : Give that reviewer some tests. Reviewers love tests. #

Patch Set 4 : MSVC fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -5 lines) Patch
M content/content_tests.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
A content/renderer/gpu/render_widget_compositor_unittest.cc View 1 2 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (11 generated)
Sami
skyostil@chromium.org changed reviewers: + jamesr@chromium.org
6 years, 3 months ago (2014-08-29 11:52:32 UTC) #1
Sami
6 years, 3 months ago (2014-08-29 11:52:43 UTC) #2
Sami
(Depends on https://codereview.chromium.org/516103003/)
6 years, 3 months ago (2014-08-29 11:54:00 UTC) #3
Sami
Excuse the spam, but for some reason it looks like the above message never got ...
6 years, 3 months ago (2014-09-02 14:01:18 UTC) #4
picksi1
https://codereview.chromium.org/521613002/diff/20001/content/renderer/gpu/render_widget_compositor.cc File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/521613002/diff/20001/content/renderer/gpu/render_widget_compositor.cc#newcode764 content/renderer/gpu/render_widget_compositor.cc:764: double interval_sec = args.interval.InSecondsF(); Is base::TimeTicks() potentially slow? Should ...
6 years, 3 months ago (2014-09-02 14:50:40 UTC) #6
Sami
https://codereview.chromium.org/521613002/diff/20001/content/renderer/gpu/render_widget_compositor.cc File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/521613002/diff/20001/content/renderer/gpu/render_widget_compositor.cc#newcode764 content/renderer/gpu/render_widget_compositor.cc:764: double interval_sec = args.interval.InSecondsF(); On 2014/09/02 14:50:40, picksi1 wrote: ...
6 years, 3 months ago (2014-09-02 14:53:30 UTC) #7
Sami
6 years, 3 months ago (2014-09-02 14:53:32 UTC) #8
jamesr
Tests?
6 years, 3 months ago (2014-09-02 19:19:05 UTC) #9
Sami
On 2014/09/02 19:19:05, jamesr wrote: > Tests? Added.
6 years, 3 months ago (2014-09-03 13:12:37 UTC) #10
jamesr
cool, lgtm
6 years, 3 months ago (2014-09-03 17:27:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/521613002/40001
6 years, 3 months ago (2014-09-03 18:03:11 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-03 19:02:23 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/11967)
6 years, 3 months ago (2014-09-03 19:25:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/521613002/80001
6 years, 3 months ago (2014-09-04 10:57:37 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2134)
6 years, 3 months ago (2014-09-04 11:46:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/521613002/80001
6 years, 3 months ago (2014-09-04 12:30:15 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47873)
6 years, 3 months ago (2014-09-04 19:30:14 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/521613002/80001
6 years, 3 months ago (2014-09-04 22:05:06 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47873)
6 years, 3 months ago (2014-09-04 22:48:43 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/521613002/80001
6 years, 3 months ago (2014-09-05 08:21:24 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:80001) as 0d42246d8f84188e2a63339b474af521125ef76a
6 years, 3 months ago (2014-09-05 08:23:11 UTC) #32
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:00 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7759d7aef4c97d3454c15607945e23595c2dfa3e
Cr-Commit-Position: refs/heads/master@{#293476}

Powered by Google App Engine
This is Rietveld 408576698