Pass more frame timing information to Blink

content/renderer/gpu/render_widget_compositor.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/render_widget_compositor.h"
 
 #include <limits>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 741 matching lines @@
 }
 
 void RenderWidgetCompositor::DidBeginMainFrame() {
   widget_->InstrumentDidBeginFrame();
 }
 
 void RenderWidgetCompositor::BeginMainFrame(const cc::BeginFrameArgs& args) {
   VLOG(2) << "RenderWidgetCompositor::BeginMainFrame";
   begin_main_frame_time_ = args.frame_time;
   begin_main_frame_interval_ = args.interval;
-  double frame_time = (args.frame_time - base::TimeTicks()).InSecondsF();
-  WebBeginFrameArgs web_begin_frame_args = WebBeginFrameArgs(frame_time);
+  double frame_time_sec = (args.frame_time - base::TimeTicks()).InSecondsF();
+  double deadline_sec = (args.deadline - base::TimeTicks()).InSecondsF();
+  double interval_sec = args.interval.InSecondsF();

[picksi1, 2014/09/02 14:50:40]

Is base::TimeTicks() potentially slow? Should we call it once and cache the
result locally?

[Sami, 2014/09/02 14:53:30]

It only constructs a TimeTicks instance that holds the value zero. To actually
get the current time you need to call base::TimeTicks::Now().

+  WebBeginFrameArgs web_begin_frame_args =
+      WebBeginFrameArgs(frame_time_sec, deadline_sec, interval_sec);
   widget_->webwidget()->beginFrame(web_begin_frame_args);
 }
 
 void RenderWidgetCompositor::Layout() {
   widget_->webwidget()->layout();
 }
 
 void RenderWidgetCompositor::ApplyScrollAndScale(
     const gfx::Vector2d& scroll_delta,
     float page_scale) {
@@ skipping 20 matching lines @@
     if (idle_time > base::TimeDelta()) {
       // Convert to 32-bit microseconds first to avoid costly 64-bit division.
       int32 idle_time_in_us = idle_time.InMicroseconds();
       int32 idle_time_in_ms = idle_time_in_us / 1000;
       blink::mainThreadIsolate()->IdleNotification(idle_time_in_ms);
     }
   }
 
   widget_->DidCommitCompositorFrame();
   widget_->didBecomeReadyForAdditionalInput();
+  widget_->webwidget()->didCommitFrameToCompositor();
 }
 
 void RenderWidgetCompositor::DidCommitAndDrawFrame() {
   widget_->didCommitAndDrawCompositorFrame();
 }
 
 void RenderWidgetCompositor::DidCompleteSwapBuffers() {
   widget_->didCompleteSwapBuffers();
   if (!threaded_)
     widget_->OnSwapBuffersComplete();
@@ skipping 11 matching lines @@
   widget_->OnSwapBuffersAborted();
 }
 
 void RenderWidgetCompositor::RateLimitSharedMainThreadContext() {
   cc::ContextProvider* provider =
       RenderThreadImpl::current()->SharedMainThreadContextProvider().get();
   provider->ContextGL()->RateLimitOffscreenContextCHROMIUM();
 }
 
 }  // namespace content