Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 521473004: Print the command line, not ['Print', 'the', 'command', 'line']. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Project:
skiacommon
Visibility:
Public.

Description

Print the command line, not ['Print', 'the', 'command', 'line']. BUG=skia: Committed: https://skia.googlesource.com/common/+/39d13eccce76b158b47778b184e665dcf0b1bf44

Patch Set 1 #

Total comments: 1

Patch Set 2 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M py/utils/shell_utils.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
mtklein@google.com changed reviewers: + borenet@google.com, mtklein@google.com
6 years, 3 months ago (2014-08-29 16:11:33 UTC) #1
mtklein
6 years, 3 months ago (2014-08-29 16:11:33 UTC) #2
borenet
https://codereview.chromium.org/521473004/diff/1/py/utils/shell_utils.py File py/utils/shell_utils.py (right): https://codereview.chromium.org/521473004/diff/1/py/utils/shell_utils.py#newcode56 py/utils/shell_utils.py:56: print ' '.join(cmd) cmd can also be a string, ...
6 years, 3 months ago (2014-08-29 16:20:28 UTC) #3
mtklein
> print ' '.join(cmd) if isinstance(cmd, list) else cmd done.
6 years, 3 months ago (2014-08-29 16:29:43 UTC) #4
borenet
LGTM
6 years, 3 months ago (2014-08-29 16:30:13 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 3 months ago (2014-08-29 16:31:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/521473004/20001
6 years, 3 months ago (2014-08-29 16:31:59 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 16:32:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 39d13eccce76b158b47778b184e665dcf0b1bf44

Powered by Google App Engine
This is Rietveld 408576698