py/utils/shell_utils.py - Issue 521473004: Print the command line, not ['Print', 'the', 'command', 'line'].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: py/utils/shell_utils.py

Issue 521473004: Print the command line, not ['Print', 'the', 'command', 'line']. (Closed) Base URL: https://skia.googlesource.com/common.git@master

Patch Set: done Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: py/utils/shell_utils.py

diff --git a/py/utils/shell_utils.py b/py/utils/shell_utils.py

index 37d124b2f025b203f95281bbd5fb977dd07f2f3c..4068b813ec0b2d49f3e1ce9fc890d2d94595862f 100644

--- a/py/utils/shell_utils.py

+++ b/py/utils/shell_utils.py

@@ -53,7 +53,7 @@ def run_async(cmd, echo=None, shell=False):

if echo is None:

echo = VERBOSE

if echo:

- print cmd

+ print ' '.join(cmd) if isinstance(cmd, list) else cmd

if 'nt' in os.name:

# Windows has a bad habit of opening a dialog when a console program

# crashes, rather than just letting it crash. Therefore, when a program

« no previous file with comments | « no previous file | no next file » | no next file with comments »